fix(core): 🐛 do not insert pseudo elements to input element

It is invalid and does not work in Firefox. Closes: #689
StarCitizenTools · Jul 16, 2023 · 0e42030 · 0e42030
1 parent 5ccab9e
commit 0e42030
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/resources/skins.citizen.styles/components/Header.less b/resources/skins.citizen.styles/components/Header.less
@@ -180,26 +180,25 @@
 		/*
 		 * Add overlay to menus as affordnance
 		 * TODO: We should use JS to add the overlay instead of abusing CSS
+		 * TODO: This does not work for TOC and Pref menu
 		*/
-		.citizen-menu-checkbox-checkbox,
-		.citizen-button {
+		.citizen-header__button {
 			contain: initial;
 
 			&[ aria-expanded='true' ] {
-				&::before {
-					position: fixed;
-					top: 0;
-					right: 0;
-					bottom: 0;
-					left: 0;
-					width: auto;
-					height: auto;
-					background-color: var( --background-color-overlay );
-					content: '';
-				}
-
-				~ .citizen-menu-checkbox-target {
-					z-index: 1;
+				~ .citizen-header__button {
+					&::before {
+						position: fixed;
+						z-index: 1;
+						top: 0;
+						right: 0;
+						bottom: 0;
+						left: 0;
+						width: auto;
+						height: auto;
+						background-color: var( --background-color-overlay );
+						content: '';
+					}
 				}
 			}
 		}

diff --git a/resources/skins.citizen.styles/components/Menu.less b/resources/skins.citizen.styles/components/Menu.less
@@ -82,6 +82,7 @@
 		height: 0;
 		padding: 0;
 		margin: 0;
+		opacity: 0;
 
 		// HACK: Fake focus styles
 		&:focus {