feat(core): ✨ only load the inline script if EnablePreferences is true

StarCitizenTools · Apr 25, 2024 · 52f4bab · 52f4bab
1 parent e5af171
commit 52f4bab
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/includes/Hooks/SkinHooks.php b/includes/Hooks/SkinHooks.php
@@ -65,11 +65,13 @@ public function onBeforePageDisplay( $out, $skin ): void {
 			return;
 		}
 
-		$script = file_get_contents( MW_INSTALL_PATH . '/skins/Citizen/resources/skins.citizen.scripts/inline.js' );
-		$script = Html::inlineScript( $script );
-		// TODO: Consider turning on cache after this is more stable
-		$script = RL\ResourceLoader::filter( 'minify-js', $script, [ 'cache' => false ] );
-		$out->addHeadItem( 'skin.citizen.inline', $script );
+		if ( $this->getConfigValue( 'CitizenEnablePreferences', $out ) === true ) {
+			$script = file_get_contents( MW_INSTALL_PATH . '/skins/Citizen/resources/skins.citizen.scripts/inline.js' );
+			$script = Html::inlineScript( $script );
+			// TODO: Consider turning on cache after this is more stable
+			$script = RL\ResourceLoader::filter( 'minify-js', $script, [ 'cache' => false ] );
+			$out->addHeadItem( 'skin.citizen.inline', $script );
+		}
 	}
 
 	/**