fix(core): 🐛 enter key should not clear search input

Use span instead of button element. As button element will make enter key triggering the clear button.
StarCitizenTools · Jul 16, 2023 · 739fa85 · 739fa85
1 parent 4cf9417
commit 739fa85
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/resources/skins.citizen.scripts/search.js b/resources/skins.citizen.scripts/search.js
@@ -155,10 +155,10 @@ function bindExpandOnSlash( window, checkbox, input ) {
  */
 function renderSearchClearButton( input ) {
 	const
-		clearButton = document.createElement( 'button' ),
+		clearButton = document.createElement( 'span' ),
 		clearIcon = document.createElement( 'span' );
 
-	clearButton.classList.add( 'citizen-search__clear', 'citizen-search__formButton', 'citizen-button' );
+	clearButton.classList.add( 'citizen-search__clear', 'citizen-search__formButton' );
 	clearIcon.classList.add( 'citizen-ui-icon', 'mw-ui-icon-wikimedia-clear' );
 	clearButton.append( clearIcon );
 

diff --git a/resources/skins.citizen.styles/components/Search.less b/resources/skins.citizen.styles/components/Search.less
@@ -29,6 +29,7 @@
 
 	&__formButton {
 		border-radius: var( --border-radius--small );
+		cursor: pointer;
 
 		.citizen-ui-icon::before {
 			transition: var( --transition-hover );