Skip to content

Commit

Permalink
fix(menu): 馃悰 avoid double view button on talk page
Browse files Browse the repository at this point in the history
In 9969479, we forced the view button to be visible to allow the return action (#845).
There are no good ways to target revision page only so we rely on the diff styles.
However, Extension:DiscussionTools inline the said styles on talk page while talk page also has
a return action registered under the associated page menu. This leaves two button serving the
same function.
  • Loading branch information
alistair3149 committed Jun 24, 2024
1 parent c47531a commit 923dded
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion skinStyles/mediawiki/mediawiki.diff.styles.less
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@

// HACK: Restore view button on revision page
// There are no good way to target revision page
.action-view #ca-view {
// The :not selector is needed because Extension:DiscussionTools loads the diff styles inline
body:not(.ns-talk) .action-view #ca-view {
position: relative !important;
width: auto;
height: auto;
Expand Down

0 comments on commit 923dded

Please sign in to comment.