fix(search): 🐛 ensure that onFocus event are properly fired

StarCitizenTools · Aug 4, 2023 · 9921a00 · 9921a00
1 parent 4a478ef
commit 9921a00
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/resources/skins.citizen.search/searchClients/mwActionApi.js b/resources/skins.citizen.search/searchClients/mwActionApi.js
@@ -82,7 +82,9 @@ function adaptApiResponse( config, query, response, showDescription ) {
 
 		// Sometimes there can be multiple redirect object for the same page, only take the one with lower index
 		if ( response.pages.length !== pageCount ) {
-			response.pages = response.pages.filter( ( obj ) => { return obj.hasOwnProperty( 'title' ); } );
+			response.pages = response.pages.filter( ( obj ) => {
+				return Object.prototype.hasOwnProperty.call( obj, 'title' );
+			} );
 		}
 	}
 

diff --git a/resources/skins.citizen.search/typeahead.js b/resources/skins.citizen.search/typeahead.js
@@ -48,9 +48,9 @@ const typeahead = {
 			updateTypeahead();
 			typeahead.form.element.parentElement.classList.add( 'citizen-search__card--expanded' );
 			typeahead.input.element.addEventListener( 'keydown', keyboardEvents );
-			typeahead.input.element.addEventListener( 'input', this.onInput );
-			typeahead.input.element.addEventListener( 'compositionstart', this.onCompositionstart );
-			typeahead.input.element.addEventListener( 'compositionend', this.onCompositionend );
+			typeahead.input.element.addEventListener( 'input', typeahead.input.onInput );
+			typeahead.input.element.addEventListener( 'compositionstart', typeahead.input.onCompositionstart );
+			typeahead.input.element.addEventListener( 'compositionend', typeahead.input.onCompositionend );
 			typeahead.input.element.addEventListener( 'blur', typeahead.onBlur );
 		},
 		onInput: function () {