Skip to content

Commit

Permalink
feat(core): ✨ add overflow handling for citizen inner header
Browse files Browse the repository at this point in the history
  • Loading branch information
alistair3149 committed Jul 20, 2023
1 parent d3cc5fd commit fab4d27
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 14 deletions.
3 changes: 1 addition & 2 deletions resources/skins.citizen.styles/common/progressbar.less
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
// Align style with the form
border-radius: 0 0 var( --border-radius--large ) var( --border-radius--large );
// Animates the progress-bar.
animation:
progress-bar
animation: progress-bar
1200ms
linear
var( --delay-progress-bar )
Expand Down
2 changes: 2 additions & 0 deletions resources/skins.citizen.styles/components/Header.less
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
flex-grow: 1;
justify-content: space-between;
gap: var( --space-xxs );
overflow-x: auto;

.citizen-menu-checkbox-checkbox:checked {
~ .citizen-header__button {
Expand All @@ -110,6 +111,7 @@
&__end {
display: flex;
flex-direction: var( --header-direction );
flex-shrink: 0; // let _inner handle the overflow
gap: var( --space-xxs );
}

Expand Down
6 changes: 2 additions & 4 deletions resources/skins.citizen.styles/layout.less
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
padding: 0 var( --padding-page );
margin: var( --space-xl ) 0; // don't collide with other components (e.g. notice)
gap: var( --space-md ) var( --space-xl );
grid-template-areas:
'header'
grid-template-areas: 'header'
'content'
'footer';
// Using auto as min value will cause overflow
Expand Down Expand Up @@ -60,8 +59,7 @@
.citizen-toc-enabled {
.citizen-body-container {
display: grid;
grid-template-areas:
'header header'
grid-template-areas: 'header header'
'content toc'
'footer footer';
grid-template-columns: minmax( 0, var( --width-layout ) ) var( --width-toc );
Expand Down
6 changes: 2 additions & 4 deletions skinStyles/extensions/MultimediaViewer/mmv.less
Original file line number Diff line number Diff line change
Expand Up @@ -507,8 +507,7 @@
// Sync with title
background-color: #000;
gap: var( --space-xs );
grid-template-areas:
'desc links'
grid-template-areas: 'desc links'
'about about';
grid-template-columns: 2fr 1fr;

Expand All @@ -517,8 +516,7 @@
gap: var( --space-lg );

@media ( max-width: @width-breakpoint-tablet ) {
grid-template-areas:
'desc desc'
grid-template-areas: 'desc desc'
'links links'
'about about';
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@
.mw-body-content > .mw-ui-container {
display: grid;
gap: var( --space-md );
grid-template-areas:
'message'
grid-template-areas: 'message'
'stats'
'form';
}
Expand Down Expand Up @@ -82,8 +81,7 @@

@media ( min-width: @width-breakpoint-tablet ) {
.mw-body-content > .mw-ui-container {
grid-template-areas:
'message message'
grid-template-areas: 'message message'
'form stats';
}

Expand Down

0 comments on commit fab4d27

Please sign in to comment.