Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ULS personal tool is not rendered for some wiki #425

Closed
lens0021 opened this issue Feb 17, 2022 · 8 comments
Closed

ULS personal tool is not rendered for some wiki #425

lens0021 opened this issue Feb 17, 2022 · 8 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@lens0021
Copy link
Contributor

Describe the Bug

Using citizen skin, there is no UniversalLanguageSelector on the personal tool portlet.

Steps to reproduce the behavior:

  1. Go to 'https://wordles.miraheze.org/wiki/Special:BlankPage?useskin=citizen'
  2. Click on 'Toggle personal menu' (👤)

Expected Behavior

<li id="ca-uls" …>…</li> should be included, like on vector (https://wordles.miraheze.org/wiki/Special:BlankPage?useskin=vector) or Star Citizen Wiki(https://star-citizen.wiki/)

System

  • MediaWiki version: 1.37.1
  • Server OS: Debian Bullseye[1]
  • Installed extensions and versions
  • PHP version: 7.4.25 (fpm-fcgi)
@lens0021 lens0021 added the bug Something isn't working label Feb 17, 2022
@lens0021 lens0021 changed the title ULS personal tool is not rendered ULS personal tool is not rendered for some wiki Feb 19, 2022
@alistair3149
Copy link
Member

Is the issue isolated to logged in users? I have noticed this issue before but wasn't able to pinpoint the cause.

@lens0021
Copy link
Contributor Author

Anonymous users also do not have the ULS. I suspect the changes of personal tools of MW1.36 are the cause.

@at-wr
Copy link

at-wr commented May 16, 2022

I have the same issue

System

  • MediaWiki version: 1.37.2
  • Server OS: Ubuntu 20.04 LTS
  • Installed extensions and versions
    ** UniversalLanguageSelector: 729194a
  • PHP version: 7.3.31 (fpm-fcgi)

@alistair3149
Copy link
Member

I can reproduce the issue now and am looking into it.

@alistair3149 alistair3149 added the help wanted Extra attention is needed label May 17, 2022
@alistair3149
Copy link
Member

I couldn't get ULS from the personal tools for some reason on 1.39.
@lens0021 Do you have some idea on what the issue might be? I couldn't figure it out.

@alistair3149 alistair3149 pinned this issue May 17, 2022
@lens0021
Copy link
Contributor Author

I guess SkinTemplate::buildPersonalUrls() changed in some way but I am not sure. More deep inspection is needed for details but I can't now.

@alistair3149
Copy link
Member

Just an update on the issue.
I am not sure what is going on with it but it should be fixed when we refactor the skin for 1.39,
which will also tackle the personal menu. It should be ready by the time 1.39 releases.

@alistair3149
Copy link
Member

No longer relevant in 1.39

@alistair3149 alistair3149 unpinned this issue Dec 1, 2022
alistair3149 added a commit that referenced this issue Feb 15, 2023
This should also fix the issue of ULS not showing up (#587, #425).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants