Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions after 'navigation' missing in Sidebar #580

Closed
Reception123 opened this issue Feb 7, 2023 · 4 comments
Closed

Additions after 'navigation' missing in Sidebar #580

Reception123 opened this issue Feb 7, 2023 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Reception123
Copy link

Describe the Bug

Only the items in the navigation section are included, further custom sections don't appear in the sidebar since 1.39.

Steps to reproduce the behavior:

  1. Open the wiki, and open the menu containing wiki links (3 lines)
  2. Notice none of the custom additions in MediaWiki:Sidebar are included for one reason or another.

Expected Behavior

Both the navigation and the custom pages section should be in the sidebar

System

MediaWiki | 1.39.1 (1c58291)
PHP | 7.4.33 (fpm-fcgi)
MariaDB | 10.5.17-MariaDB-1:10.5.17+maria~deb11-log

Original task and wiki: https://phabricator.miraheze.org/T10450

@Reception123 Reception123 added the bug Something isn't working label Feb 7, 2023
@alistair3149
Copy link
Member

It seems to be a duplicate of https://phabricator.miraheze.org/T10334.

The issue can be reproduced when the user has ManageWiki access, in which the user can only get the first portlet of the sidebar. I suspect that there are some incompatibility between how ManageWiki and Citizen handle sidebar, but I'm not sure the exact cause even after looking into the source.

@alistair3149 alistair3149 added the help wanted Extra attention is needed label Feb 7, 2023
@Reception123
Copy link
Author

It seems to be a duplicate of https://phabricator.miraheze.org/T10334.

The issue can be reproduced when the user has ManageWiki access, in which the user can only get the first portlet of the sidebar. I suspect that there are some incompatibility between how ManageWiki and Citizen handle sidebar, but I'm not sure the exact cause even after looking into the source.

As far as I'm aware this wasn't an issue before 1.39, as I imagine someone would've pointed it out before.

@Reception123
Copy link
Author

Oh you're right, when logged out it works fine.

@williamsp
Copy link

Hi, could someone check what's wrong with nucarnival.miraheze.org? Here, logged out users also cannot see additional sections on the sidebar.

Details here: https://phabricator.miraheze.org/T10334#209346

alistair3149 added a commit that referenced this issue Feb 15, 2023
This should fix the issue where SidebarBeforeOutput is not working in some scenario.

Fix: #580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants