Preference Menu is Empty

[keepersdungeon]

After upgrading to v2.13.0 the preference menu is now empty and for some reason after downgrading back to v.2.12, the text in the preference menu looks like ⧼prefs-citizen-theme-option-light⧽ instead of light or ⧼prefs-citizen-lineheight-label⧽ instead of line height

System

• MediaWiki version 1.41.1
• PHP version 8.2.4 (litespeed)

Thank you!

[alistair3149]

There are significant rework on the preference menu and it might be caching that causes both of the issues you mentioned. Do you have any errors in your browser console log?

[andre-paulo98]

I installed 2.13.0 on a brand new wiki and I have the same issue.

There's this error in console:

addPortlet.polyfill.js:13 Uncaught TypeError: portlet.querySelector is not a function
    at addDefaultPortlet (addPortlet.polyfill.js:13:21)
    at addPortlet (addPortlet.polyfill.js:49:10)
    at resources/skins.citizen.preferences/clientPreferences.js (clientPreferences.js:25:57)
    at require (load.php?lang=en-gb&modules=startup&only=scripts&raw=1&skin=citizen:8:863)
    at HTMLButtonElement.initPanel (skins.citizen.preferences.js:102:29)
addDefaultPortlet @ addPortlet.polyfill.js:13
addPortlet @ addPortlet.polyfill.js:49
resources/skins.citizen.preferences/clientPreferences.js @ clientPreferences.js:25
require @ load.php?lang=en-gb&modules=startup&only=scripts&raw=1&skin=citizen:8
initPanel @ skins.citizen.preferences.js:102

[alistair3149]

Will look into it

[alistair3149]

Please let me know if the latest commit fixes it for you!

[andre-paulo98]

Different error, but seems like result is the same

clientPreferences.js:294 Uncaught (in promise) TypeError: addPortlet is not a function
   at makeClientPreference (clientPreferences.js:294:19)
   at clientPreferences.js:335:4
   at Array.forEach (<anonymous>)
   at clientPreferences.js:334:41
   at new Promise (<anonymous>)
   at Object.render (clientPreferences.js:333:9)
   at HTMLButtonElement.initPanel (skins.citizen.preferences.js:120:21)
makeClientPreference @ clientPreferences.js:294
(anonymous) @ clientPreferences.js:335
(anonymous) @ clientPreferences.js:334
render @ clientPreferences.js:333
initPanel @ skins.citizen.preferences.js:120

[alistair3149]

Would you be able to check if it is fixed now?

[andre-paulo98]

works now 👍, thanks! 💖