Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close button for search popup not working as expected #895

Closed
ratte1303 opened this issue Jul 4, 2024 · 1 comment · Fixed by #893 or #901
Closed

Close button for search popup not working as expected #895

ratte1303 opened this issue Jul 4, 2024 · 1 comment · Fixed by #893 or #901
Labels
bug Something isn't working

Comments

@ratte1303
Copy link

Describe the Bug

Clicking the close button after opening the search popup results in the search popup opening again with animation instead of closing.
This is especially important since on Safari mobile you can only close it via the close button because touching the rest of the content doesnt do anything and you would be stuck with the serach popup open.

Expected Behavior

Table of contents popup closes after clicking close.

System

MediaWiki version: 1.42
Server OS: Debian 11
Installed extensions and versions: only the Citizen skin
PHP version 8.1
Live demo: arbeit.wiki
@ratte1303 ratte1303 added the bug Something isn't working label Jul 4, 2024
alistair3149 added a commit that referenced this issue Jul 4, 2024
@alistair3149
fix(dropdown): 🐛 merge conflicting dismiss event handlers
317296e 
Focus loss and click outside are basically using the same function.
Merging them should avoid them conflicting with each other.

Related: #895
@alistair3149 alistair3149 mentioned this issue Jul 4, 2024
Merged
@alistair3149
Copy link
Member

The closing button issue should be resolved with 317296e. As for the Safari bug, it is still an issue with the commit?

alistair3149 added a commit that referenced this issue Jul 8, 2024
@alistair3149
fix(dropdown): 🐛 use both touchstart and mousedown event listener for…
a4593d7 
… click outside event

On iOS devices, click event listeners don't work when the target does not have cursor: pointer.
This should resolve the issue for iOS browsers.

Related: #895
@alistair3149 alistair3149 mentioned this issue Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@alistair3149 @ratte1303