New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button is not clickable when DarkMode is on #39
Comments
@alistair3149 may you have a look at this? |
Do you have a live page with the issue? |
https://femiwiki.com/index.php?oldid=299612&uselang=en#%EC%98%81%EC%83%81 was, but I have applied MediaWiki:Common.css for it. |
Okay found the issue. |
Would you mind to check if the fix works for you? |
The patch works for my local MediaWiki instance. I am sorry I cannot test it on https://femiwiki.com because it is not my own wiki, but my team's. The release pipeline is little long to test. |
No worries. Thanks for verifying it! Closing the issue now. |
* fix: Enforce stacking order for consent element (#39) * ci: ignore line length too long for allow attribute * WIP: Simplify DOM structure There are many unnessecary DOM elements in EV. Let's remove the unneeded parts to make it lighter. Also using the new Parsoid media structure so it stays inline with core * WIP: reimplement alignment behaviors * fix: enforce max-width to prevent overflow (#38) * WIP: let container control the size of all elements This should allow us to change everything by just adjusting the container size. Also removed the autoresize implementation since it does not work at all, we will revisit it later * refactor: CSS only approach to autoresize * refactor: Change `autoResize` parameter for `autoresize` By setting `|autoresize=true`, EV will use all available width of the parent element * refactor: clean up inline styles * feat: add caption styles * style: address PHPCP errors --------- Co-authored-by: H. C. Kruse <hannes@octofox.de>
Describe the bug
The 'Load video' button is not focusable when DarkMode is on.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The video should be loaded.
Screenshots
Screencast from 2023-01-09 22-59-08.webm
Technical information:
Additional context
Setting the z-index to
1
solves this, but maybe there is a nicer solution.The text was updated successfully, but these errors were encountered: