Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Don't add backtick if columns is configured #183

Merged
merged 1 commit into from Feb 10, 2023

Conversation

banmoy
Copy link
Collaborator

@banmoy banmoy commented Feb 10, 2023

What type of PR is this:

  • bugfix
  • feature
  • enhancement
  • refactor
  • others

Which issues of this PR fixes :

Problem Summary(Required) :

introduced by #173. Don't add backticks when sink.properties.columns is configured

Checklist:

  • I have added test cases for my bug fix or my new feature
  • I have added user document for my new feature or new function

@xlfjcg
Copy link
Contributor

xlfjcg commented Feb 10, 2023

I hope the stream load sdk is an independent module, and not often changed at the same time. because other place may use it

@banmoy banmoy merged commit b659455 into StarRocks:main Feb 10, 2023
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Feb 10, 2023
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Mar 6, 2023
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Mar 6, 2023
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Mar 6, 2023
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants