[Bugfix] Don't add first/end new line delimiter for csv #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
xlfjcg
reviewed
Feb 14, 2023
...rocks-stream-load-sdk/src/main/java/com/starrocks/data/load/stream/StreamLoadDataFormat.java
Outdated
Show resolved
Hide resolved
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
xlfjcg
approved these changes
Feb 14, 2023
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Mar 6, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Mar 6, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Mar 6, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Mar 6, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Mar 6, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
that referenced
this pull request
Mar 6, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
that referenced
this pull request
Mar 6, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
that referenced
this pull request
Mar 6, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
that referenced
this pull request
Mar 6, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
that referenced
this pull request
Mar 6, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Problem Summary(Required) ：
CSV will always add first/end new line delimiter , and it will lead to wrong result if a none new-line delimiter is specified
Checklist: