Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add retry metrics for sink version V1 #229

Merged
merged 1 commit into from
May 19, 2023

Conversation

banmoy
Copy link
Collaborator

@banmoy banmoy commented May 18, 2023

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes #

Problem Summary(Required) :

some useful metrics for sink V1. flushTimeNsWithRetry, totalFlushRetry and flushRetry are added in this PR

metric 描述 类型 单位
totalFlushRows flush数据总条数 counter  
totalFlushBytes flush数据总bytes counter byte
totalFlushSucceededTimes flush次数 counter  
totalFlushTimeNs flush数据总耗时(包括重试) counter nano
totalFlushTimeNsWithoutRetries flush数据总耗时(不包括重试) counter nano
flushTimeNs 成功flush的耗时(不包括重试) Histogram nano
flushTimeNsWithRetry 成功flush的耗时(包括重试) Histogram nano
totalFlushRetry 所有成功flush的重试总数 counter  
flushRetry 成功flush的重试数 Histogram  

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
@banmoy banmoy merged commit f504c92 into StarRocks:main May 19, 2023
2 of 3 checks passed
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Aug 28, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Aug 28, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Aug 28, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit that referenced this pull request Sep 11, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit that referenced this pull request Sep 11, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants