Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix typos in StarRocksStreamLoadVisitor #230

Merged
merged 1 commit into from
May 25, 2023

Conversation

EMsnap
Copy link
Contributor

@EMsnap EMsnap commented May 22, 2023

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Problem Summary(Required) :

Fix typos in StarRocksStreamLoadVisitor

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function

@CLAassistant
Copy link

CLAassistant commented May 22, 2023

CLA assistant check
All committers have signed the CLA.

Signed-off-by: pengzirui <zirui@apache.org>
@EMsnap
Copy link
Contributor Author

EMsnap commented May 22, 2023

@xlfjcg Hi PTAL at this pr, thanks!

@EMsnap
Copy link
Contributor Author

EMsnap commented May 23, 2023

@banmoy Hi, I discovered some typos when reading the source code, could u please take a look?

@banmoy banmoy merged commit 3ebb67b into StarRocks:main May 25, 2023
3 checks passed
@banmoy
Copy link
Collaborator

banmoy commented May 25, 2023

@EMsnap Thanks for your PR. merged

banmoy pushed a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Aug 28, 2023
banmoy pushed a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Aug 28, 2023
banmoy pushed a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Aug 28, 2023
banmoy pushed a commit that referenced this pull request Sep 11, 2023
Signed-off-by: pengzirui <zirui@apache.org>
banmoy pushed a commit that referenced this pull request Sep 11, 2023
Signed-off-by: pengzirui <zirui@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants