[Enhancement] no need to getLabelState if an existing label is finished #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd failure to reduce fe http request Signed-off-by: shuzz <shuzz@shuyilink.com>
szza
changed the title
szza
changed the title
|
@szza Thanks for your PR |
1 similar comment
|
@szza Thanks for your PR |
banmoy
pushed a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Aug 28, 2023
…ed (StarRocks#231) Signed-off-by: shuzz <shuzz@shuyilink.com>
banmoy
pushed a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Aug 28, 2023
…ed (StarRocks#231) Signed-off-by: shuzz <shuzz@shuyilink.com>
banmoy
pushed a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Aug 28, 2023
…ed (StarRocks#231) Signed-off-by: shuzz <shuzz@shuyilink.com>
banmoy
pushed a commit
that referenced
this pull request
Sep 11, 2023
…ed (#231) Signed-off-by: shuzz <shuzz@shuyilink.com>
banmoy
pushed a commit
that referenced
this pull request
Sep 11, 2023
…ed (#231) Signed-off-by: shuzz <shuzz@shuyilink.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #
Problem Summary(Required) ：
the benefit of this pr have two aspects:
DefaultStreamLoader.sendfailed, we can use the the context ofexistingJobStatusfield in theStreamLoadResponseto replacegetLabelStatehttp request;sink.version = 2andat-least-oncesink semantic，we just use BE's ipAndHttpport and thenDefaultStreamLoader.senddirectly send data to BE node, instead of redirecting to BE through FE , so further eliminate redirect problem.Checklist: