Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Remove useless stack trace log for sink V1 #232

Merged
merged 1 commit into from
May 29, 2023

Conversation

banmoy
Copy link
Collaborator

@banmoy banmoy commented May 29, 2023

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes #
StarRocksSinkManager#checkFlushException will log current stack trace. It's not useful for troubleshooting, but occupies much of disk space if failover is frequent, so remove this log.

Problem Summary(Required) :

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
@banmoy banmoy merged commit 9d146c8 into StarRocks:main May 29, 2023
3 of 4 checks passed
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Aug 28, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Aug 28, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Aug 28, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit that referenced this pull request Sep 11, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit that referenced this pull request Sep 11, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants