Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Detect partial columns write according to Flink schema #235

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

banmoy
Copy link
Collaborator

@banmoy banmoy commented Jun 8, 2023

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes #

Problem Summary(Required) :

Currently if users want to write only partial columns into StarRock, need to specify sink.properties.columns to tell the column names of these partial columns, but it's actually not necessary because users already define these columns when creating a flink table, and the connector can get those information from the table schema.
This PR contains these improvements

  • infer whether it's partial write by comparing the schemas between Flink and StarRocks
  • if it's partial write, the connector will set sink.properties.columns automatically, otherwise this parameter can be omitted

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
@banmoy banmoy changed the title [Enhancement] Support to write partial columns to StarRocks according to Flink schema [Enhancement] Support to write partial columns according to Flink schema Jun 8, 2023
@banmoy banmoy changed the title [Enhancement] Support to write partial columns according to Flink schema [Enhancement] Detect partial columns write according to Flink schema Jun 8, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
@banmoy banmoy merged commit 1603957 into StarRocks:main Jun 8, 2023
2 of 3 checks passed
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Aug 28, 2023
banmoy added a commit to banmoy/starrocks-connector-for-apache-flink that referenced this pull request Aug 28, 2023
banmoy added a commit that referenced this pull request Sep 11, 2023
…235)

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy added a commit that referenced this pull request Sep 11, 2023
…235)

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants