[Enhancement] Support to deal with update_before record #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
xlfjcg
approved these changes
Jul 6, 2023
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Aug 28, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Aug 28, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Aug 28, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Aug 28, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
that referenced
this pull request
Sep 11, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
banmoy
added a commit
that referenced
this pull request
Sep 11, 2023
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #
Problem Summary(Required) ：
Whether to ignore update_before records. In general, update_before and update_after have the same primary key, and appear in pair, so we only need to write the update_after record to StarRocks, and ignore the update_before. But that hasn't always been the case, for example, if the user updates one row with the primary key changed in the OLTP, and Flink cdc will generate a before and after records, but they have the different primary keys. The connector should delete the update_before row, and insert the update_after row in StarRocks, and this options should be set false for this case. Note that how to set this options depends on the user case.
Checklist: