[Doc] Improve the format and language of the doc for sink #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellolilyliuyi
commented
Aug 31, 2023
docs/content/connector-sink.md
Outdated
|
|
||
| ## Version requirements | ||
|
|
||
| | Connector | Flink | StarRocks | Java | Scala | | ||
| |-----------|--------------------------|---------------| ---- |-----------| | ||
| | 1.2.7 | 1.11,1.12,1.13,1.14,1.15 | 2.1 and later | 8 | 2.11,2.12 | | ||
| | 1.2.7 | 1.11,1.12,1.13,1.14,1.15 | 2.5 and later| 8 | 2.11,2.12 | |
There was a problem hiding this comment.
版本这边是不是可以写sr 2.5 及以后
There was a problem hiding this comment.
suggest not. Flink connector has been used for a long time, and there are still a lot of users using SR 2.3 and before. It will confuse them if we say only support since 2.5
hellolilyliuyi
changed the title
banmoy
reviewed
Sep 4, 2023
docs/content/connector-sink.md
Outdated
|
|
||
| ## Version requirements | ||
|
|
||
| | Connector | Flink | StarRocks | Java | Scala | | ||
| |-----------|--------------------------|---------------| ---- |-----------| | ||
| | 1.2.7 | 1.11,1.12,1.13,1.14,1.15 | 2.1 and later | 8 | 2.11,2.12 | | ||
| | 1.2.7 | 1.11,1.12,1.13,1.14,1.15 | 2.5 and later| 8 | 2.11,2.12 | |
There was a problem hiding this comment.
suggest not. Flink connector has been used for a long time, and there are still a lot of users using SR 2.3 and before. It will confuse them if we say only support since 2.5
docs/content/connector-sink.md
Outdated
Comment on lines
5
to
7
| The Flink connector supports DataStream API, Table API & SQL, and Python API. | ||
|
|
||
| The Flink connector boasts a higher and more stable performance than [flink-connector-jdbc](https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/jdbc/) provided by Apache Flink®. |
There was a problem hiding this comment.
How about merge these two lines to one line?
docs/content/connector-sink.md
Outdated
| | table-name | Yes | NONE | The name of the table that you want to use to load data into StarRocks. | | ||
| | username | Yes | NONE | The username of the account that you want to use to load data into StarRocks. | | ||
| | table-name | Yes | NONE | The name of the table that you want to use to load data into StarRocks. | | ||
| | username | Yes | NONE | The username of the account that you want to use to load data into StarRocks. The account must have load permissions on the StarRocks table. See [User privileges](https://docs.starrocks.io/en-us/latest/administration/User_privilege). | |
There was a problem hiding this comment.
also need SELECT privileges
banmoy
changed the title
banmoy
changed the title
banmoy
pushed a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Sep 6, 2023
banmoy
pushed a commit
to banmoy/starrocks-connector-for-apache-flink
that referenced
this pull request
Sep 6, 2023
banmoy
pushed a commit
that referenced
this pull request
Sep 11, 2023
Signed-off-by: hellolilyliuyi <hellolilyliuyi123@163.com>
banmoy
pushed a commit
that referenced
this pull request
Sep 11, 2023
Signed-off-by: hellolilyliuyi <hellolilyliuyi123@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #
Problem Summary(Required) ：
Checklist: