[BugFix] Fix SDK write failure for non-default tables #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zaorang Yang <zaorangy@gmail.com>
banmoy
reviewed
Oct 26, 2023
| @@ -174,6 +174,17 @@ public StreamLoadTableProperties getTableProperties(String uniqueKey) { | |||
| return tablePropertiesMap.getOrDefault(uniqueKey, defaultTableProperties); | |||
| } | |||
There was a problem hiding this comment.
we can remove getTableProperties(String database, String table) and getTableProperties(String uniqueKey) to avoid misusing
banmoy
reviewed
Oct 26, 2023
Comment on lines
127
to
128
| columns(streamLoadTableProperties.getColumns()); | ||
| enableUpsertDelete(streamLoadTableProperties.isEnableUpsertDelete()); |
There was a problem hiding this comment.
columns and upsertDelete may be different for different tables, so it's better not to copy them?
banmoy
reviewed
Oct 26, 2023
| @@ -114,6 +118,20 @@ private Builder() { | |||
|
|
|||
| } | |||
|
|
|||
| // This function does not copy the uniqueKey and properties attributes because the uniqueKey | |||
| // is generated in the StreamLoadTableProperties constructor, and the properties are automatically | |||
| // populated during the build process. | |||
There was a problem hiding this comment.
only db, table, and columns are populated in the build process. What about other properties such as timeout
Signed-off-by: Zaorang Yang <zaorangy@gmail.com>
banmoy
approved these changes
Oct 26, 2023
banmoy
pushed a commit
that referenced
this pull request
Dec 4, 2023
Signed-off-by: Zaorang Yang <zaorangy@gmail.com>
banmoy
pushed a commit
that referenced
this pull request
Dec 4, 2023
Signed-off-by: Zaorang Yang <zaorangy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #
Problem Summary(Required) ：
For the Stream Load SDK, if the table to be written to is a non-default table, the DefaultStreamLoader.send method still requests SR to write data to the default table, causing the stream load job to fail. This PR fixes this issue.
Checklist: