Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fail to add custom stream load table properties #356

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

Lyang77
Copy link
Contributor

@Lyang77 Lyang77 commented Apr 18, 2024

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Problem Summary(Required) :

判断有误导致自定义properties无法添加进httpPut的header中

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

@banmoy banmoy changed the title fix(StreamLoadProperties):设置默认表和database判断错误,导致添加的properties无法生效 [BugFix] Fail to add custom stream load table properties Apr 29, 2024
@banmoy
Copy link
Collaborator

banmoy commented Apr 29, 2024

@Lyang77 Thanks for the fix. Could you sign the CLA?

@Lyang77
Copy link
Contributor Author

Lyang77 commented Apr 29, 2024

@Lyang77 Thanks for the fix. Could you sign the CLA?

@banmoy ok

@banmoy
Copy link
Collaborator

banmoy commented Apr 29, 2024

LGTM

@banmoy banmoy merged commit cc8689d into StarRocks:main Apr 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants