Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Refactor the documents #66

Merged
merged 6 commits into from
Jul 31, 2023
Merged

[Doc] Refactor the documents #66

merged 6 commits into from
Jul 31, 2023

Conversation

banmoy
Copy link
Collaborator

@banmoy banmoy commented Jul 24, 2023

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes #

Problem Summary(Required) :

Currently the documents of connector are maintained in starrocks/docs and docs.zh-cn for english and chinese version respectively. The problem is that we need to submit a PR to each project (total 3 PRs) if there is a change, such as adding a configuration: the code pr for the connector, the two PRs for english and chinese documents, which's cumbersome.

One way to improve the process is integrating the english documents to the connector project, updating the documents when developing the code in one PR, and synchronizing the changes to starrocks official documents in batch when releasing a new version of connector. Keep the chinese document as it is.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function

README.md Outdated
This Connector can support reading data stored in StarRocks through Apache Spark™.
# StarRocks Connector for Apache Spark™

The connector supports to read from and write to StarRocks through Apache Spark™.

## Upstream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why mention doris here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ability of reading from starrocks refers to doris-spark-connector

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
@banmoy banmoy merged commit 46543a0 into StarRocks:main Jul 31, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants