[Enhancement] Optimize row-string converter #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
Which issues of this PR fixes :
Fixes #
Problem Summary(Required) :
When inserting into RS table, we need to convert
InternalRow
to json or csv string. Previously this was implemented viaAbstractRowStringConverter.fromRow
. Even though the schema is definite, it still calls theconvert
method per row.This PR has been tested on real data of 640 MB of orc data having almost 3 columns and 100 million rows, the Optimized stage with one partition is performed in 3 minutes compare to 9.1 minutes. Here below flame graphs for 120-sec sample of the execution of the test query using Spark 3.3 in local mode.
Before this PR:
spark ui
After this PR:
spark ui
Checklist: