Replace OLAPStatus with Status

[sduzh]

Status is used in StarRocks to report success and various kinds of errors, but some legacy code still using the deprecated OLAPStatus as the return value, should replace them with Status and remove OLAPStatus finally.

[PuneetDabral]

sir can i ..please assign it to me ..so i can do my first contribution here ....but i need your support ....!!

[sduzh]

sir can i ..please assign it to me ..so i can do my first contribution here ....but i need your support ....!!

Welcome to contribute! feel free to ask me questions.

[PuneetDabral]

sir can you please tell me the step by step!!procedure (sorry to disturb you i am new in open source )

[sduzh]

sir can you please tell me the step by step!!procedure (sorry to disturb you i am new in open source )

1. Create a fork of this repo
2. Cone your fork of this repository from GitHub to your local computer
3. Create a topic branch on your local computer
4. Make commits
5. ./run_ut.sh --be --run to make sure all the tests are passed
6. Push your changes to a topic branch in your fork of the repository
7. Submit a pull request

[PuneetDabral]

sir i can only change the word OLAPStatus to Status....and my branch name is topic am i write ...sir

[sduzh]

sir i can only change the word OLAPStatus to Status....and my branch name is topic am i write ...sir

I'm afraid not. If you modify the return type of a function, you need to modify the implementation of the function to replace the OLAPStatus values with the appropriate Status values, e.g. replace OLAP_SUCCESS with Status::OK(), replace OLAP_ERR_INPUT_PARAMETER_ERROR with Status ::InvalidArgument(), and you also need to change all the places where this function is called.

As for the branch name, maybe you can just name it replace-OLAPStatus-with-Status or something alike.

[PuneetDabral]

sir i am totally confuse ...but i will start..are you in discord on any other where i can discuss about this

[sduzh]

sir i am totally confuse ...but i will start..are you in discord on any other where i can discuss about this

I don't have a discord account ... we can discuss this on Github now.

[PuneetDabral]

ok sir i clone it to my local device and create a branch in topic name ....sorry sir to disturb you....sir i am totally demotivated that i never do this...