Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] keep at least one version whose create_time is before expire time in remove_expire_versions (backport #15654) #15726

Merged
merged 1 commit into from Dec 24, 2022
Merged

[BugFix] keep at least one version whose create_time is before expire time in remove_expire_versions (backport #15654) #15726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions be/src/storage/tablet_updates.cpp
View file
Open in desktop
Expand Up @@ -1423,12 +1423,16 @@ void TabletUpdates::_erase_expired_versions(int64_t expire_time,
LOG(WARNING) << "tablet deleted when erase_expired_versions tablet:" << _tablet.tablet_id();
return;
}
for (int i = 0; i < _apply_version_idx; i++) {
if (_edit_version_infos[i]->creation_time <= expire_time) {
expire_list->emplace_back(std::move(_edit_version_infos[i]));
} else {
// only keep at most one version which is before expire_time
int keep_index_min = _apply_version_idx;
while (keep_index_min > 0) {
if (_edit_version_infos[keep_index_min]->creation_time <= expire_time) {
break;
}
keep_index_min--;
}
for (int i = 0; i < keep_index_min; i++) {
expire_list->emplace_back(std::move(_edit_version_infos[i]));
}
auto n = expire_list->size();
_edit_version_infos.erase(_edit_version_infos.begin(), _edit_version_infos.begin() + n);
Expand Down