[Enhancement] Reduce cache miss when evaluate lots of expr in aggregate #15998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -16,6 +16,7 @@ | |||
|
|
|||
| #include <utility> | |||
There was a problem hiding this comment.
warning: 'utility' file not found [clang-diagnostic-error]
#include <utility>
^| @@ -16,6 +16,7 @@ | |||
|
|
|||
| #include <utility> | |||
|
|
|||
| #include "column/vectorized_fwd.h" | |||
There was a problem hiding this comment.
warning: 'column/vectorized_fwd.h' file not found [clang-diagnostic-error]
#include "column/vectorized_fwd.h"
^
kangkaisen
reviewed
Dec 30, 2022
kangkaisen
reviewed
Dec 30, 2022
fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/ExtractAggregateColumn.java
Outdated
Show resolved
Hide resolved
Seaven
reviewed
Dec 30, 2022
fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/ExtractAggregateColumn.java
Outdated
Show resolved
Hide resolved
Seaven
reviewed
Dec 30, 2022
fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/ExtractAggregateColumn.java
Outdated
Show resolved
Hide resolved
Seaven
reviewed
Dec 30, 2022
fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/ExtractAggregateColumn.java
Outdated
Show resolved
Hide resolved
|
run starrocks_admit_test |
|
run starrocks_fe_unittest |
|
run starrocks_admit_test |
|
run starrocks_admit_test |
1. move some function call expr from project node to aggregate node 2. evaluate function call expr before call aggregate node
stdpain
force-pushed
the
extract_agg_column
branch
from
d1cd86c
to
d15fd9d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
[FE PR Coverage Check]😍 pass : 78 / 80 (97.50%) file detail
|
|
run starrocks_admit_test |
|
SonarCloud Quality Gate failed.
|
kangkaisen
approved these changes
Jan 3, 2023
Seaven
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
#9118
Problem Summary(Required) ：
cache miss
before:
after:
Checklist:
Bugfix cherry-pick branch check: