Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Optimize the performance for regexp_replace #16356

Merged
merged 3 commits into from Jan 10, 2023

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Jan 9, 2023

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes #

Problem Summary(Required) :

performance case:

SELECT max(REGEXP_REPLACE(Referer, '^https?://(?:www\.)?([^/]+)/.*$', '\1')) AS k, COUNT(*) AS c FROM hits where Referer<>'';

baseline: 3.55
after-upgrade-re2: 2.75
update-re2 and optimize allocate: 2.12

upstream: https://code-review.googlesource.com/c/re2/+/60910

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 2.5
    • 2.4
    • 2.3
    • 2.2

@silverbullet233
Copy link
Contributor

run starrocks_admit_test

mofeiatwork
mofeiatwork previously approved these changes Jan 9, 2023
silverbullet233
silverbullet233 previously approved these changes Jan 9, 2023
@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Jan 9, 2023
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@stdpain stdpain enabled auto-merge (squash) January 9, 2023 04:23
@github-actions github-actions bot removed the Approved Ready to merge label Jan 9, 2023
@stdpain
Copy link
Contributor Author

stdpain commented Jan 9, 2023

run starrocks_be_unittest image

1 similar comment
@stdpain
Copy link
Contributor Author

stdpain commented Jan 9, 2023

run starrocks_be_unittest image

@stdpain
Copy link
Contributor Author

stdpain commented Jan 9, 2023

run starrocks_admit_test image

@stdpain
Copy link
Contributor Author

stdpain commented Jan 9, 2023

run starrocks_be_unittest image

1 similar comment
@wangruin
Copy link
Contributor

wangruin commented Jan 9, 2023

run starrocks_be_unittest image

kangkaisen
kangkaisen previously approved these changes Jan 9, 2023
@stdpain
Copy link
Contributor Author

stdpain commented Jan 9, 2023

run starrocks_be_unittest image

@stdpain
Copy link
Contributor Author

stdpain commented Jan 9, 2023

run starrocks_admit_test image

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@stdpain
Copy link
Contributor Author

stdpain commented Jan 9, 2023

run starrocks_admit_test image

@stdpain stdpain merged commit 8c04b6c into StarRocks:main Jan 10, 2023
@github-actions github-actions bot removed the be-build label Jan 10, 2023
@github-actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants