Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Adjust NULL_TYPE hack processing(2) #17483

Merged
merged 4 commits into from Feb 10, 2023
Merged

[BugFix] Adjust NULL_TYPE hack processing(2) #17483

merged 4 commits into from Feb 10, 2023

Conversation

liuyehcf
Copy link
Contributor

@liuyehcf liuyehcf commented Feb 7, 2023 •
edited

Signed-off-by: liuyehcf 1559500551@qq.com

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #https://github.com/StarRocks/StarRocksTest/issues/1853
Fixes #https://github.com/StarRocks/StarRocksTest/issues/1767

Hack TYPE_NULL for all branches in ScalarOperatorToExpr

This pr is a contiunation of preous work #17107, in which we only handle visitArray visitVariableReference and visitConstant. But other branches also need the hacking process as well, so I make it up in this pr.

Make sure MapColumn' key/value, ArrayColumn's element is nullable

For ArrayColumn, element must be nullable to facilitate handling the nested types. and key/value for MapColumn as well.

But, some place will pass non-nullable column to ArrayColumn/MapColumn's ctor, so I add an DCHECK and modify the realted tests.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 2.5
    • 2.4
    • 2.3
    • 2.2

@github-actions github-actions bot removed the be-build label Feb 7, 2023
@github-actions github-actions bot removed the be-build label Feb 7, 2023
@github-actions github-actions bot removed the be-build label Feb 7, 2023
@github-actions github-actions bot removed the be-build label Feb 8, 2023
@github-actions github-actions bot removed the be-build label Feb 8, 2023
@github-actions github-actions bot removed the be-build label Feb 8, 2023
@github-actions github-actions bot removed the be-build label Feb 8, 2023
@liuyehcf
[BugFix] Fix NULL_TYPE assertion
3ef7e36 
Signed-off-by: liuyehcf <1559500551@qq.com>
@github-actions github-actions bot removed the be-build label Feb 8, 2023
@github-actions github-actions bot removed the be-build label Feb 8, 2023
@liuyehcf liuyehcf changed the title [BugFix] Fix NULL_TYPE assertion [BugFix] Adjust NULL_TYPE hack processing(2) Feb 8, 2023
@liuyehcf
update array_column ctor
4a1c6a6 
Signed-off-by: liuyehcf <1559500551@qq.com>
@liuyehcf liuyehcf dismissed stale reviews from kangkaisen and packy92 via acf2c9e February 9, 2023 11:54
@github-actions github-actions bot removed Approved Ready to merge be-build labels Feb 9, 2023
@liuyehcf
fix crash
87b4e78 
Signed-off-by: liuyehcf <1559500551@qq.com>
@liuyehcf liuyehcf force-pushed the bugfix branch 2 times, most recently from 962cf92 to 87b4e78 Compare February 9, 2023 13:38
@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 36 / 40 (90.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/plan/ScalarOperatorToExpr.java 31 35 88.57% [200, 203, 204, 205]
🔵 com/starrocks/analysis/Expr.java 2 2 100.00% []
🔵 com/starrocks/analysis/CloneExpr.java 3 3 100.00% []

@github-actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Feb 10, 2023
@liuyehcf liuyehcf enabled auto-merge (squash) February 10, 2023 02:05
@StarRocks StarRocks deleted a comment from wanpengfei-git Feb 10, 2023
@liuyehcf
Copy link
Contributor Author

run starrocks_admit_test

@kangkaisen kangkaisen merged commit 87163ff into StarRocks:main Feb 10, 2023
@github-actions github-actions bot removed Approved Ready to merge be-build labels Feb 10, 2023
Jay-ju pushed a commit to Jay-ju/starrocks that referenced this pull request Feb 27, 2023
@liuyehcf @Jay-ju
[BugFix] Adjust NULL_TYPE hack processing(2) (StarRocks#17483)
c72d74e 
Signed-off-by: liuyehcf <1559500551@qq.com>
liuyehcf added a commit to liuyehcf/starrocks that referenced this pull request Feb 27, 2023
@liuyehcf
[BugFix] Adjust NULL_TYPE hack processing(2) (StarRocks#17483)
41661e9 
Signed-off-by: liuyehcf <1559500551@qq.com>
liuyehcf added a commit to liuyehcf/starrocks that referenced this pull request Feb 27, 2023
@liuyehcf
[BugFix] Adjust NULL_TYPE hack processing(2) (StarRocks#17483)
1c2ae34 
Signed-off-by: liuyehcf <1559500551@qq.com>
liuyehcf added a commit to liuyehcf/starrocks that referenced this pull request Feb 27, 2023
@liuyehcf
[BugFix] Adjust NULL_TYPE hack processing(2) (StarRocks#17483)
9100206 
Signed-off-by: liuyehcf <1559500551@qq.com>
kangkaisen pushed a commit that referenced this pull request Feb 27, 2023
@liuyehcf
[Cherrypick-2.5][BugFix] Adjust NULL_TYPE hack processing (#17107,#17483
4464a34 
) (#18563)



Signed-off-by: liuyehcf <1559500551@qq.com>
kangkaisen pushed a commit that referenced this pull request Feb 27, 2023
@liuyehcf
[Cherrypick-2.3][BugFix] Adjust NULL_TYPE hack processing (#17107,#17483
32bca1d 
) (#18550)


---------

Signed-off-by: liuyehcf <1559500551@qq.com>
kangkaisen pushed a commit that referenced this pull request Feb 27, 2023
@liuyehcf
[Cherrypick-2.4][BugFix] Adjust NULL_TYPE hack processing (#17107,#17483
22dcd4f 
) (#18556)


---------

Signed-off-by: liuyehcf <1559500551@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seaven Seaven Seaven approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

@packy92 packy92 packy92 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liuyehcf @wanpengfei-git @Seaven @kangkaisen @packy92