Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support range optimize in join #31601

Closed
wants to merge 14 commits into from

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Sep 21, 2023

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@stdpain stdpain force-pushed the support_range_join branch 4 times, most recently from 846176a to b2725ff Compare September 22, 2023 16:54
packy92 and others added 7 commits September 23, 2023 13:06
Signed-off-by: stephen <stephen5217@163.com>
Signed-off-by: packy92 <wangchao@starrocks.com>
Signed-off-by: stdpain <drfeng08@gmail.com>
…nd scan range (StarRocks#28468) (StarRocks#31683)

Signed-off-by: Youngwb <yangwenbo_mailbox@163.com>
Signed-off-by: stdpain <drfeng08@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 5 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

0.0% 0.0% Coverage
0.9% 0.9% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😞 fail : 214 / 391 (54.73%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/Utils.java 0 1 00.00% [399]
🔵 com/starrocks/connector/iceberg/cost/IcebergFileStats.java 2 33 06.06% [127, 135, 136, 139, 143, 144, 146, 147, 149, 150, 151, 156, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 275, 276, 279, 280, 281, 283, 286]
🔵 com/starrocks/sql/optimizer/statistics/StatisticsCalculator.java 3 33 09.09% [296, 297, 298, 299, 1370, 1371, 1372, 1373, 1374, 1375, 1376, 1377, 1378, 1379, 1382, 1384, 1385, 1386, 1387, 1388, 1391, 1394, 1395, 1401, 1402, 1403, 1404, 1405, 1406, 1408]
🔵 com/starrocks/sql/optimizer/operator/logical/LogicalIcebergScanOperator.java 1 4 25.00% [62, 66, 67]
🔵 com/starrocks/connector/iceberg/cost/IcebergStatisticProvider.java 50 126 39.68% [86, 93, 94, 101, 102, 103, 105, 167, 169, 170, 171, 172, 173, 174, 175, 216, 217, 218, 219, 220, 221, 226, 227, 228, 229, 230, 231, 237, 246, 247, 298, 299, 310, 311, 326, 327, 329, 330, 332, 335, 336, 337, 338, 339, 340, 342, 343, 344, 345, 346, 347, 348, 350, 351, 353, 354, 356, 360, 361, 364, 365, 367, 369, 370, 373, 374, 375, 376, 380, 383, 385, 386, 387, 389, 390, 392]
🔵 com/starrocks/connector/iceberg/IcebergMetadata.java 1 2 50.00% [289]
🔵 com/starrocks/qe/SessionVariable.java 5 10 50.00% [1104, 1108, 1109, 1311, 1312]
🔵 com/starrocks/sql/optimizer/rule/transformation/DeriveRangeJoinPredicateRule.java 89 115 77.39% [75, 86, 122, 131, 138, 139, 145, 146, 169, 178, 185, 192, 193, 194, 195, 197, 198, 199, 209, 210, 211, 213, 214, 215, 218, 229]
🔵 com/starrocks/sql/optimizer/statistics/ColumnStatistic.java 21 25 84.00% [271, 272, 276, 277]
🔵 com/starrocks/sql/optimizer/Optimizer.java 1 1 100.00% []
🔵 com/starrocks/catalog/IcebergTable.java 5 5 100.00% []
🔵 com/starrocks/sql/optimizer/rule/RuleType.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/statistics/ExpressionStatisticCalculator.java 35 35 100.00% []

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😞 fail : 16 / 72 (22.22%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exec/hash_joiner.cpp 0 5 00.00% [64, 162, 166, 172, 174]
🔵 src/exec/hash_join_components.cpp 0 3 00.00% [37, 38, 39]
🔵 src/exec/pipeline/hashjoin/hash_joiner_factory.cpp 0 26 00.00% [19, 20, 21, 22, 23, 24, 25, 38, 39, 40, 43, 44, 45, 46, 49, 50, 52, 55, 56, 57, 60, 61, 62, 65, 66, 67]
🔵 src/exec/join_hash_map.h 0 6 00.00% [702, 703, 704, 705, 706, 707]
🔵 src/column/binary_column.h 0 1 00.00% [45]
🔵 src/exec/join_hash_map.cpp 8 21 38.10% [366, 368, 369, 370, 410, 411, 417, 418, 419, 425, 427, 428, 430]
🔵 src/column/nullable_column.cpp 3 5 60.00% [103, 104]
🔵 src/column/binary_column.cpp 2 2 100.00% []
🔵 src/column/fixed_length_column_base.cpp 1 1 100.00% []
🔵 src/exec/pipeline/pipeline_driver_executor.cpp 2 2 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants