Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] percentile disc #36352

Merged
merged 3 commits into from Dec 4, 2023

Conversation

before-Sunrise
Copy link
Contributor

Why I'm doing:

What I'm doing:

cp from #17628 and #21248

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: before-Sunrise <unclejyj@gmail.com>
…s null

Signed-off-by: before-Sunrise <unclejyj@gmail.com>
Signed-off-by: before-Sunrise <unclejyj@gmail.com>
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

github-actions bot commented Dec 4, 2023

[FE Incremental Coverage Report]

fail : 20 / 39 (51.28%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/analyzer/ExpressionAnalyzer.java 1 16 06.25% [1031, 1032, 1034, 1035, 1037, 1038, 1040, 1041, 1042, 1043, 1044, 1045, 1046, 1048, 1049]
🔵 com/starrocks/sql/analyzer/FunctionAnalyzer.java 6 10 60.00% [408, 411, 412, 416]
🔵 com/starrocks/catalog/FunctionSet.java 13 13 100.00% []

Copy link

github-actions bot commented Dec 4, 2023

[BE Incremental Coverage Report]

fail : 24 / 118 (20.34%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exprs/agg/nullable_aggregate.h 0 1 00.00% [892]
🔵 src/exprs/agg/percentile_cont.h 13 106 12.26% [111, 113, 114, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 136, 138, 141, 142, 143, 144, 146, 148, 149, 150, 151, 155, 156, 159, 160, 161, 162, 163, 164, 167, 168, 171, 172, 173, 174, 175, 176, 178, 179, 181, 182, 186, 188, 190, 193, 194, 195, 196, 197, 200, 201, 202, 204, 205, 207, 208, 210, 211, 212, 213, 214, 216, 217, 220, 223, 225, 226, 228, 229, 230, 232, 233, 234, 235, 237, 238, 239, 240, 241, 242, 243, 244, 291, 311, 318, 320, 322, 333]
🔵 src/types/logical_type.cpp 3 3 100.00% []
🔵 src/exprs/agg/factory/aggregate_factory.hpp 2 2 100.00% []
🔵 src/exprs/agg/factory/aggregate_resolver_others.cpp 6 6 100.00% []

@kangkaisen kangkaisen merged commit 7af7979 into StarRocks:branch-3.0 Dec 4, 2023
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants