Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support alter session variables in create and alter materialized view command (backport #19668) #37401

Merged
merged 3 commits into from Dec 20, 2023
Merged

[Enhancement] Support alter session variables in create and alter materialized view command (backport #19668) #37401

merged 3 commits into from Dec 20, 2023

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Dec 20, 2023 •
edited by wanpengfei-git

Signed-off-by: Kevin Li ming.moriarty@gmail.com
(cherry picked from commit 5809e18)

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@LiShuMing
[Enhancement] Support alter session variables in create and alter mat…
182376a 
…erialized view command (StarRocks#19668)

Signed-off-by: Kevin Li <ming.moriarty@gmail.com>
(cherry picked from commit 5809e18)
@LiShuMing
fix bugs
cd0ba96 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
@LiShuMing
[BugFix] ShowCreateMaterializedView should show session properties (S…
e6b0b52 
…tarRocks#25256)

After AlterMV session properties, ShowMV should display the changed properties.
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

14 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 57 / 76 (75.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java 3 10 30.00% [226, 227, 228, 229, 230, 231, 232]
🔵 com/starrocks/scheduler/TaskRun.java 15 22 68.18% [117, 118, 123, 124, 125, 130, 131]
🔵 com/starrocks/alter/Alter.java 15 19 78.95% [374, 379, 384, 389]
🔵 com/starrocks/server/LocalMetastore.java 10 11 90.91% [3664]
🔵 com/starrocks/catalog/MaterializedView.java 14 14 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@LiShuMing LiShuMing merged commit f7dbf00 into StarRocks:branch-2.5 Dec 20, 2023
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ABingHuang ABingHuang ABingHuang approved these changes

Assignees

@LiShuMing LiShuMing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LiShuMing @ABingHuang