Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] active mv automatically (backport #32829) #38521

Merged
merged 4 commits into from Jan 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 5, 2024

This is an automatic backport of pull request #32829 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Fixes #issue

Introduce a daemon thread MVActiveChecker:

  1. Try to activate MV, if it's not set to inactive manually
  2. The default check interval is 1 minute, user could modify it through admin set frontend config('mv_active_checker_interval_seconds'='300')

Use case:

  1. The base table of MV could be dropped and created everyday, for Hive external table
  2. Without this mechanism, user need to activate it in the workflow, which is tedious

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@mergify mergify bot added the conflicts label Jan 5, 2024
@mergify mergify bot mentioned this pull request Jan 5, 2024
22 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) January 5, 2024 05:55
@mergify mergify bot closed this Jan 5, 2024
auto-merge was automatically disabled January 5, 2024 05:55

Pull request was closed

Copy link
Contributor Author

mergify bot commented Jan 5, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-32829 branch January 5, 2024 05:56
@mofeiatwork mofeiatwork restored the mergify/bp/branch-2.5/pr-32829 branch January 5, 2024 05:56
@mofeiatwork mofeiatwork reopened this Jan 5, 2024
mofeiatwork and others added 3 commits January 5, 2024 14:06
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit c1e3a1e)
Signed-off-by: Murphy <mofei@starrocks.com>
Signed-off-by: Murphy <mofei@starrocks.com>
@mofeiatwork mofeiatwork force-pushed the mergify/bp/branch-2.5/pr-32829 branch 2 times, most recently from e173d78 to 50d630c Compare January 5, 2024 06:57
Signed-off-by: Murphy <mofei@starrocks.com>
@mofeiatwork mofeiatwork force-pushed the mergify/bp/branch-2.5/pr-32829 branch from 50d630c to 6d5fc73 Compare January 5, 2024 07:37
Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

16 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Jan 5, 2024

[FE Incremental Coverage Report]

fail : 59 / 87 (67.82%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/alter/Alter.java 0 7 00.00% [366, 574, 575, 633, 634, 663, 682]
🔵 com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java 3 9 33.33% [638, 639, 848, 976, 993, 994]
🔵 com/starrocks/server/GlobalStateMgr.java 3 5 60.00% [1443, 1451]
🔵 com/starrocks/catalog/MaterializedView.java 8 11 72.73% [678, 689, 1101]
🔵 com/starrocks/scheduler/MVActiveChecker.java 36 46 78.26% [57, 58, 59, 60, 61, 96, 97, 112, 113, 114]
🔵 com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java 4 4 100.00% []
🔵 com/starrocks/catalog/OlapTable.java 1 1 100.00% []
🔵 com/starrocks/common/Config.java 2 2 100.00% []
🔵 com/starrocks/server/LocalMetastore.java 1 1 100.00% []
🔵 com/starrocks/alter/SchemaChangeJobV2.java 1 1 100.00% []

Copy link

github-actions bot commented Jan 5, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) January 6, 2024 13:05
@wanpengfei-git wanpengfei-git merged commit 1c4eb9a into branch-2.5 Jan 6, 2024
28 of 29 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-2.5/pr-32829 branch January 6, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants