New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Wrong array element type in ORC reader #39233
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ricky <rickif@qq.com>
@Mergifyio rebase |
✅ Branch has been successfully rebased |
rickif
force-pushed
the
fix/orc-reader
branch
from
January 17, 2024 02:30
dc4af6f
to
fdde2f6
Compare
Signed-off-by: ricky <rickif@qq.com>
rickif
force-pushed
the
fix/orc-reader
branch
from
January 17, 2024 14:22
fdde2f6
to
0d52558
Compare
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 0 / 1 (00.00%) file detail
|
Smith-Cruise
approved these changes
Jan 18, 2024
trueeyu
approved these changes
Jan 18, 2024
wyb
approved these changes
Jan 18, 2024
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
starrocks/be/src/formats/orc/orc_chunk_reader.cpp
Lines 553 to 554 in d5e2ab3
starrocks/be/src/formats/orc/orc_chunk_reader.cpp
Lines 552 to 554 in d5e2ab3
The
_fill_functions
are built recursively, and the lower level incorrectly use the_src_slot_descriptors
as input.What I'm doing:
This PR corrects this issue.
Fixes #39234
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: