Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Wrong array element type in ORC reader #39233

Merged
merged 2 commits into from Jan 29, 2024

Conversation

rickif
Copy link
Contributor

@rickif rickif commented Jan 16, 2024

Why I'm doing:

_fill_functions[src_index](cvb, col, 0, _batch->numElements, slot_desc->type(),
_root_selected_mapping->get_column_id_or_child_mapping(src_index).orc_mapping, this);

ColumnPtr& col = (*chunk)->get_column_by_slot_id(slot_desc->id());
_fill_functions[src_index](cvb, col, 0, _batch->numElements, slot_desc->type(),
_root_selected_mapping->get_column_id_or_child_mapping(src_index).orc_mapping, this);

The _fill_functions are built recursively, and the lower level incorrectly use the _src_slot_descriptors as input.
What I'm doing:
This PR corrects this issue.
Fixes #39234

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: ricky <rickif@qq.com>
@github-actions github-actions bot added the 2.5 label Jan 16, 2024
@mergify mergify bot assigned rickif Jan 16, 2024
@rickif
Copy link
Contributor Author

rickif commented Jan 17, 2024

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Jan 17, 2024

rebase

✅ Branch has been successfully rebased

Signed-off-by: ricky <rickif@qq.com>
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 0 / 1 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/formats/orc/orc_chunk_reader.cpp 0 1 00.00% [553]

@wyb wyb enabled auto-merge (squash) January 18, 2024 02:53
@wyb wyb merged commit 93ef51f into StarRocks:branch-2.5 Jan 29, 2024
22 of 23 checks passed
@rickif rickif deleted the fix/orc-reader branch January 29, 2024 02:00
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Jan 29, 2024
Copy link
Contributor

mergify bot commented Jan 29, 2024

backport branch-2.5

✅ Backports have been created

  • Backport to branch branch-2.5 not needed, change already in branch branch-2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants