Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] The decimal creation type is consistent with the display type (backport #38639) #39297

Merged
merged 2 commits into from Jan 18, 2024

Conversation

Astralidea
Copy link
Contributor

@Astralidea Astralidea commented Jan 17, 2024

Why I'm doing:
When using the following statement to create a table

CREATE TABLE `testdecimal` (
  `obj_id` string NOT NULL COMMENT "",
  `lab_numr` decimal(38, 10) NULL COMMENT ""
) ENGINE=OLAP 
DUPLICATE KEY(`obj_id`)
COMMENT ""
DISTRIBUTED BY HASH(`obj_id`) BUCKETS 10 
PROPERTIES (
"replication_num" = "1",
"in_memory" = "false",
"storage_format" = "DEFAULT",
"enable_persistent_index" = "true"
);

Then after executing show create table

CREATE TABLE `testdecimal` (
  `obj_id` varchar(65533) NOT NULL COMMENT "客户ID",
  `lab_numr` decimal128(38, 10) NULL COMMENT "标签编号"
) ENGINE=OLAP 
DUPLICATE KEY(`obj_id`)
DISTRIBUTED BY HASH(`obj_id`) BUCKETS 10 
PROPERTIES (
"replication_num" = "1",
"in_memory" = "false",
"enable_persistent_index" = "true",
"replicated_storage" = "true",
"fast_schema_evolution" = "true",
"compression" = "LZ4"
);

decimal->decimal128
string->varchar(65533)

The decimal type is relatively stable now, so show create table should remain consistent, while string is just a syntactic sugar, so it should not be changed for the time being.

What I'm doing:
Keep the decimal the same as when created, and the string will not be modified.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Astralidea <astralidea@163.com>
Signed-off-by: Astralidea <astralidea@163.com>
Copy link

[FE Incremental Coverage Report]

pass : 7 / 7 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/ArrayType.java 3 3 100.00% []
🔵 com/starrocks/catalog/ScalarType.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/operator/scalar/CastOperator.java 3 3 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@Astralidea Astralidea enabled auto-merge (squash) January 18, 2024 02:04
@Astralidea Astralidea merged commit c517b1d into StarRocks:branch-3.1 Jan 18, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants