Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] support internal-sql log (backport #40453) #40682

Merged
merged 1 commit into from Feb 19, 2024

Conversation

Seaven
Copy link
Contributor

@Seaven Seaven commented Feb 4, 2024

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Seaven <seaven_7@qq.com>
Copy link

sonarcloud bot commented Feb 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link

github-actions bot commented Feb 4, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Feb 4, 2024

[FE Incremental Coverage Report]

pass : 73 / 89 (82.02%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/statistic/AnalyzeMgr.java 0 1 00.00% [191]
🔵 com/starrocks/http/action/LogAction.java 0 8 00.00% [73, 76, 79, 85, 88, 93, 94, 95]
🔵 com/starrocks/statistic/FullStatisticsCollectJob.java 1 2 50.00% [228]
🔵 com/starrocks/statistic/StatisticExecutor.java 4 6 66.67% [117, 343]
🔵 com/starrocks/common/AuditLog.java 3 4 75.00% [56]
🔵 com/starrocks/common/Log4jConfig.java 59 62 95.16% [303, 307, 348]
🔵 com/starrocks/common/Config.java 6 6 100.00% []

@Seaven Seaven enabled auto-merge (squash) February 5, 2024 03:26
auto-merge was automatically disabled February 5, 2024 09:29

Base branch was modified

@Seaven Seaven merged commit 1b170ae into StarRocks:branch-3.1 Feb 19, 2024
38 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants