Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] support regex_extact_all (backport #27990) #42178

Merged
merged 2 commits into from Mar 6, 2024
Merged

[Feature] support regex_extact_all (backport #27990) #42178

merged 2 commits into from Mar 6, 2024

Conversation

Seaven
Copy link
Contributor

@Seaven Seaven commented Mar 6, 2024 •
edited by github-actions bot

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@Seaven
[Feature] support regex_extact_all (StarRocks#27990)
82c7b76 
Fixes StarRocks#19815

And fix `longest match`
before:
```
MySQL td> select regexp_extract("aEbECEdE", "(.*?E)", 1);
+-----------------------------------------+
| regexp_extract('aEbECEdE', '(.*?E)', 1) |
+-----------------------------------------+
| aEbECEdE                                |
+-----------------------------------------+
```

after:
```
MySQL td> select regexp_extract("aEbECEdE", "(.*?E)", 1);
+-----------------------------------------+
| regexp_extract('aEbECEdE', '(.*?E)', 1) |
+-----------------------------------------+
| aE                                      |
+-----------------------------------------+
```

Signed-off-by: Seaven <seaven_7@qq.com>
@Seaven
[BugFix] fix regexp_extract with 0 group (StarRocks#38821)
17945e8 
Signed-off-by: Seaven <seaven_7@qq.com>
@Seaven Seaven requested a review from a team as a code owner March 6, 2024 03:19
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 6, 2024
@mergify mergify bot assigned Seaven Mar 6, 2024
@Seaven Seaven changed the title [BugFix] fix regexp_extract with 0 group (backport #38821) [Feature] support regex_extact_all (backport #27990) Mar 6, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Seaven Seaven merged commit 86420d2 into StarRocks:branch-3.1 Mar 6, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdpain stdpain stdpain approved these changes

@wangsimo0 wangsimo0 wangsimo0 approved these changes

Assignees

@Seaven Seaven

Labels
documentation Improvements or additions to documentation version:3.1.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Seaven @stdpain @wangsimo0