-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] support iceberg query with branch/tag/version/timestamp #47997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
stephen-shelby
force-pushed
the
timetravel
branch
from
July 8, 2024 11:33
ebc9e09
to
39f4368
Compare
fe/fe-core/src/main/java/com/starrocks/connector/PointerType.java
Outdated
Show resolved
Hide resolved
stephen-shelby
force-pushed
the
timetravel
branch
2 times, most recently
from
July 9, 2024 03:45
cead2b9
to
fe4ef57
Compare
stephen-shelby
changed the title
[Feature] support iceberg query with branch/tag/version/timestamp
[UT] support iceberg query with branch/tag/version/timestamp
Jul 9, 2024
stephen-shelby
force-pushed
the
timetravel
branch
from
July 9, 2024 07:08
fe4ef57
to
db03fd1
Compare
DorianZheng
reviewed
Jul 9, 2024
DorianZheng
reviewed
Jul 9, 2024
DorianZheng
reviewed
Jul 9, 2024
fe/fe-core/src/main/java/com/starrocks/connector/ConnectorTableVersion.java
Show resolved
Hide resolved
DorianZheng
reviewed
Jul 9, 2024
fe/fe-core/src/main/java/com/starrocks/connector/ConnectorTableVersion.java
Show resolved
Hide resolved
DorianZheng
reviewed
Jul 9, 2024
stephen-shelby
force-pushed
the
timetravel
branch
2 times, most recently
from
July 9, 2024 09:15
54ac201
to
690a934
Compare
Youngwb
reviewed
Jul 9, 2024
fe/fe-core/src/main/java/com/starrocks/sql/analyzer/QueryAnalyzer.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/sql/analyzer/QueryAnalyzer.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/connector/iceberg/IcebergMetadata.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/connector/iceberg/IcebergMetadata.java
Show resolved
Hide resolved
Youngwb
previously approved these changes
Jul 9, 2024
stephen-shelby
force-pushed
the
timetravel
branch
from
July 9, 2024 14:25
f782d4f
to
9e44c03
Compare
stephen-shelby
changed the title
[UT] support iceberg query with branch/tag/version/timestamp
[Feature] support iceberg query with branch/tag/version/timestamp
Jul 10, 2024
stephen-shelby
force-pushed
the
timetravel
branch
3 times, most recently
from
July 10, 2024 10:32
9cff642
to
48b7f00
Compare
Youngwb
previously approved these changes
Jul 10, 2024
stephen-shelby
force-pushed
the
timetravel
branch
from
July 10, 2024 11:49
48b7f00
to
6ecd663
Compare
dirtysalt
previously approved these changes
Jul 10, 2024
fe/fe-core/src/main/java/com/starrocks/catalog/IcebergTable.java
Outdated
Show resolved
Hide resolved
HangyuanLiu
previously approved these changes
Jul 11, 2024
stephen-shelby
dismissed stale reviews from HangyuanLiu and dirtysalt
via
July 11, 2024 03:16
fc4f4b2
fe/fe-core/src/main/java/com/starrocks/connector/ScanTableVersion.java
Outdated
Show resolved
Hide resolved
Signed-off-by: stephen <stephen5217@163.com>
Signed-off-by: stephen <stephen5217@163.com>
Signed-off-by: stephen <stephen5217@163.com>
stephen-shelby
force-pushed
the
timetravel
branch
2 times, most recently
from
July 15, 2024 06:25
f0f3c06
to
588604b
Compare
Signed-off-by: stephen <stephen5217@163.com>
stephen-shelby
force-pushed
the
timetravel
branch
from
July 15, 2024 06:29
588604b
to
90cb6d2
Compare
Quality Gate passedIssues Measures |
Youngwb
reviewed
Jul 15, 2024
fe/fe-core/src/main/java/com/starrocks/connector/iceberg/IcebergMetadata.java
Show resolved
Hide resolved
Youngwb
approved these changes
Jul 15, 2024
[FE Incremental Coverage Report]✅ pass : 94 / 115 (81.74%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
dirtysalt
approved these changes
Jul 15, 2024
Seaven
approved these changes
Jul 15, 2024
gengjun-git
approved these changes
Jul 15, 2024
HangyuanLiu
approved these changes
Jul 15, 2024
14 tasks
zhangheihei
pushed a commit
to zhangheihei/starrocks
that referenced
this pull request
Jul 18, 2024
…arRocks#47997) Signed-off-by: stephen <stephen5217@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
syntax:
In common, any version information corresponds to a snapshot id, so for iceberg, we parse all version information like branch/tag/timestamp as snasphotId then use it.
Fixes #issue
#47846
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: