[FixBug] Fix lose of meta data bug after alter routine load #6937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padmejin
reviewed
Jun 7, 2022
fe/fe-core/src/main/java/com/starrocks/load/routineload/RoutineLoadJob.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/load/routineload/RoutineLoadJob.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/load/RoutineLoadDesc.java
Outdated
Show resolved
Hide resolved
meegoo
reviewed
Jun 7, 2022
| } | ||
| } catch (Exception e) { | ||
| LOG.error("error happens when parsing create/alter routine load stmt: " + origStmt.originStmt, e); | ||
| return null; |
There was a problem hiding this comment.
why return null not throw exception, inconsistent with previous behavior
There was a problem hiding this comment.
If exception is thrown here, the fe will start failed. I'm afraid that there may be some corner case I have not considered. This is not a critical problem, so we just return null, and the load desc can be null.
Astralidea
previously approved these changes
Jun 7, 2022
|
run starrocks_fe_unittest |
gengjun-git
force-pushed
the
fix_alter_routine_load_bug
branch
from
421ce93
to
3e6d0ff
Compare
[FE PR Coverage check]😍 pass : 80 / 85 (94.12%) file detail
|
wyb
approved these changes
Jun 7, 2022
Astralidea
approved these changes
Jun 7, 2022
gengjun-git
added a commit
to gengjun-git/starrocks
that referenced
this pull request
Jun 7, 2022
…s#6937) When routine load serializes the load properties(columns/rows separator, column list, partitions, where filter), it stores the sql statement, and get the load properties by parsing the sql for deserialization. But after alter routine load is done, it will only keep the alter statement, this will cause the loss of metadata. We should merge the alter sql with the origin create sql to retain all load properties.
gengjun-git
added a commit
that referenced
this pull request
Jun 7, 2022
…6971) When routine load serializes the load properties(columns/rows separator, column list, partitions, where filter), it stores the sql statement, and get the load properties by parsing the sql for deserialization. But after alter routine load is done, it will only keep the alter statement, this will cause the loss of metadata. We should merge the alter sql with the origin create sql to retain all load properties.
gengjun-git
added a commit
to gengjun-git/starrocks
that referenced
this pull request
Jun 10, 2022
…s#6937) (StarRocks#6971) When routine load serializes the load properties(columns/rows separator, column list, partitions, where filter), it stores the sql statement, and get the load properties by parsing the sql for deserialization. But after alter routine load is done, it will only keep the alter statement, this will cause the loss of metadata. We should merge the alter sql with the origin create sql to retain all load properties.
gengjun-git
added a commit
to gengjun-git/starrocks
that referenced
this pull request
Jun 10, 2022
…s#6937) When routine load serializes the load properties(columns/rows separator, column list, partitions, where filter), it stores the sql statement, and get the load properties by parsing the sql for deserialization. But after alter routine load is done, it will only keep the alter statement, this will cause the loss of metadata. We should merge the alter sql with the origin create sql to retain all load properties.
gengjun-git
added a commit
that referenced
this pull request
Jun 10, 2022
…6971) (#7068) When routine load serializes the load properties(columns/rows separator, column list, partitions, where filter), it stores the sql statement, and get the load properties by parsing the sql for deserialization. But after alter routine load is done, it will only keep the alter statement, this will cause the loss of metadata. We should merge the alter sql with the origin create sql to retain all load properties.
chaoyli
pushed a commit
that referenced
this pull request
Jun 11, 2022
When routine load serializes the load properties(columns/rows separator, column list, partitions, where filter), it stores the sql statement, and get the load properties by parsing the sql for deserialization. But after alter routine load is done, it will only keep the alter statement, this will cause the loss of metadata. We should merge the alter sql with the origin create sql to retain all load properties.
abc982627271
pushed a commit
to abc982627271/starrocks
that referenced
this pull request
Jun 22, 2022
…s#6937) When routine load serializes the load properties(columns/rows separator, column list, partitions, where filter), it stores the sql statement, and get the load properties by parsing the sql for deserialization. But after alter routine load is done, it will only keep the alter statement, this will cause the loss of metadata. We should merge the alter sql with the origin create sql to retain all load properties.
jaogoy
pushed a commit
to jaogoy/starrocks
that referenced
this pull request
Nov 15, 2023
* fix linting Signed-off-by: DanRoscigno <dan@roscigno.com> * fix linting Signed-off-by: DanRoscigno <dan@roscigno.com> * fix linting Signed-off-by: DanRoscigno <dan@roscigno.com> * fix links in 2.3 --------- Signed-off-by: DanRoscigno <dan@roscigno.com> Co-authored-by: evelyn.zhaojie <98087056+evelynzhaojie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #6936
Problem Summary(Required) ：
When routine load serializes the load properties(columns/rows separator, column list, partitions, where filter), it stores the sql statement, and get the load properties by parsing the sql for deserialization. But after
alter routine loadis done, it will only keep the alter statement, this will cause the loss of metadata. We should merge the alter sql with the origin create sql to retain all load properties.