Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] optimize JNI call for JDBC external table #9944

Merged
merged 3 commits into from
Aug 21, 2022

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Aug 12, 2022

What type of PR is this:

  • bug
  • feature
  • enhancement
  • refactor
  • others

Which issues of this PR fixes :

for #9748

Problem Summary(Required) :

optimize JNI call for JDBC external table:

mysql> select count(id_tinyint) from jdbc_tbl;
baseline: 0.16 sec patched: 0.10 sec
mysql> select count(id_tinyint),count(id_smallint),count(id_int),count(id_bigint),count(id_date), count(id_varchar),count(id_datetime),count(id_decimal) from jdbc_tbl;
baseline: 1.07 sec patched:0.50 sec

Checklist:

  • I have added test cases for my bug fix or my new feature
  • I have added user document for my new feature or new function

@silverbullet233
Copy link
Contributor

run starrocks_admit_test

1 similar comment
@stdpain
Copy link
Contributor Author

stdpain commented Aug 15, 2022

run starrocks_admit_test

kangkaisen
kangkaisen previously approved these changes Aug 19, 2022
@stdpain
Copy link
Contributor Author

stdpain commented Aug 19, 2022

run starrocks_admit_test

@kangkaisen kangkaisen enabled auto-merge (squash) August 19, 2022 06:13
@stdpain
Copy link
Contributor Author

stdpain commented Aug 19, 2022

run starrocks_admit_test

@@ -173,73 +175,84 @@ Status JDBCScanner::_precheck_data_type(const std::string& java_class, SlotDescr
"one of tinyint,smallint,int,bigint",
slot_desc->col_name()));
}
return TYPE_SMALLINT;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wide integer casted to narrow interger should be forbidden.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wide integer cast to narrow integer overflow will report a Cast Exception

be/src/exec/vectorized/jdbc_scanner.cpp Show resolved Hide resolved
@stdpain
Copy link
Contributor Author

stdpain commented Aug 20, 2022

run starrocks_admit_test

1 similar comment
@stdpain
Copy link
Contributor Author

stdpain commented Aug 20, 2022

run starrocks_admit_test

@stdpain
Copy link
Contributor Author

stdpain commented Aug 20, 2022

run starrocks_be_unittest

@stdpain
Copy link
Contributor Author

stdpain commented Aug 20, 2022

run all

1 similar comment
@wanpengfei-git
Copy link
Collaborator

run all

@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@stdpain
Copy link
Contributor Author

stdpain commented Aug 20, 2022

run starrocks_be_unittest

@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Aug 20, 2022
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants