Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate in applyPatch #187

Merged
merged 2 commits into from
Jul 21, 2017
Merged

Validate in applyPatch #187

merged 2 commits into from
Jul 21, 2017

Conversation

alshakero
Copy link
Collaborator

Fixes: #186

@alshakero alshakero requested a review from tomalec July 19, 2017 14:49
tomalec
tomalec reviewed Jul 20, 2017
View reviewed changes
Copy link
Collaborator

@tomalec tomalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this?

tomalec
tomalec approved these changes Jul 21, 2017
View reviewed changes
Copy link
Collaborator

@tomalec tomalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alshakero alshakero merged commit 13687a1 into master Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomalec tomalec tomalec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alshakero @tomalec