Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate: properly escape pointer paths #19

Merged
merged 1 commit into from
Oct 11, 2013

Conversation

carlos8f
Copy link
Contributor

No description provided.

@carlos8f
Copy link
Contributor Author

benchmark:

before patch

before

after patch

after

@warpech
Copy link
Collaborator

warpech commented Oct 10, 2013

Thanks @carlos8f for a greatly prepared pull reuest. I will merge it with the source

@Starcounter-Jack can you remind what was the reason for ~1, ~0 stuff in first place? Those were some special triggers, I suppose? Maybe it just can be removed now.

@carlos8f
Copy link
Contributor Author

@warpech ~0 and ~1 are the escaped (literal) versions of ~ and /, respectively, according to the JSON pointer spec.

@warpech
Copy link
Collaborator

warpech commented Oct 10, 2013

Ah, I oversaw it... So apply takes escaping in consideration (though fails on multiple escaped characters), while generate does not consider them at all

@carlos8f
Copy link
Contributor Author

correct :)

@warpech warpech merged commit 82dc572 into Starcounter-Jack:master Oct 11, 2013
@warpech
Copy link
Collaborator

warpech commented Oct 11, 2013

Thanks, I included your fix in v0.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants