Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imported-template may receive new model for old view #112

Closed
3 tasks done
tomalec opened this issue Sep 5, 2018 · 3 comments
Closed
3 tasks done

imported-template may receive new model for old view #112

tomalec opened this issue Sep 5, 2018 · 3 comments
Assignees
@tomalec
Labels
bug

Comments

@tomalec
Copy link
Contributor

tomalec commented Sep 5, 2018

Steps to reproduce

  1. Stamp starcounter-include from dom-bind,
  2. Change entire view-model to one that changes href of a view,
  3. Change entire view-model to one that has the same view, but do it before the view from 2. is loaded.
  4. Check the model of old view elements before new view is loaded

Live Demo

Expected result

There should be old model (from step 1) attached

Actual result

The new model (from step 3) is attached

Browsers affected

  • Chrome
  • Firefox
  • Edge
  • [?] Safari 9
  • [?] Safari 8
  • [?] IE 11

Screenshot
@tomalec tomalec added the bug label Sep 5, 2018
@tomalec tomalec self-assigned this Sep 6, 2018
@tomalec tomalec modified the milestones: VICO starcounter-include stability, Web Platform Team urgent issues Sep 6, 2018
tomalec added a commit that referenced this issue Sep 6, 2018
@tomalec
Add a test-case for changing view-models twice faster than loading co…
1882554 
…ntent

#112
@tomalec
Copy link
Contributor Author

tomalec commented Sep 7, 2018

It seems we had an incorrectly implemented test that should fail dbc5e50#diff-d2023b39f944df7b221779867b7533f6R209

@warpech
Copy link
Contributor

warpech commented Sep 10, 2018

We discussed today with @tomalec that he will first attempt fixing that by changing Polymer binding code in palindrom-client. If that fails, he will consider removing single imported-template with multiple scopes with multiple imported-templates.

tomalec added a commit to Palindrom/palindrom-client that referenced this issue Sep 21, 2018
@tomalec
Merge pull request #79 from Palindrom/Starcounter/starcounter-include…
e1c636b 
…/issues/112-reset-state-once

 Reset state, by changing the object once,
@warpech warpech removed this from the Web Platform Team urgent issues milestone Feb 13, 2019
@miyconst
Copy link
Member

Won't be fixed, since the component is not relevant for Starcounter 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomalec tomalec

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomalec @warpech @miyconst