Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zh-cn.lng #64

Closed
wants to merge 4 commits into from
Closed

Update zh-cn.lng #64

wants to merge 4 commits into from

Conversation

chyanbo
Copy link

@chyanbo chyanbo commented Jan 31, 2024

add some items and fix some errors.

Copy link
Collaborator

@magnumpci magnumpci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for these @chyanbo .

When you added these (seemingly missing English lines), did they render your Chineses translations? I ask as I may need to get with the developers if they did not (meaning, they need to be observed by the app itself).

Again, thanks.

Sean Drohan
Stardock Product Lifecycle Manager

add some items.
@chyanbo
Copy link
Author

chyanbo commented Feb 6, 2024

Yes, these translations can be rendered normally.

@magnumpci
Copy link
Collaborator

There appears to be some conflict with the encoding since we rearranged how the repo was structured (to account for UTF-16 LE).

Thus I will have to commit your lines (885-895) manually to the main branch\zh-cn.lng.

I will do so and give you the proper credit in the lang file and the subsequent changelog when released.

Thank you very much for your time and effort.

Sean Drohan
Stardock Product Lifecycle Manager

@magnumpci magnumpci closed this Feb 7, 2024
magnumpci added a commit that referenced this pull request Feb 7, 2024
Manual edit for change made by @chyanbo
#64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants