Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mq_Tutorial quest fails to register remote events #714

Closed
Constellation-VASCO opened this issue Dec 3, 2023 · 1 comment
Closed

mq_Tutorial quest fails to register remote events #714

Constellation-VASCO opened this issue Dec 3, 2023 · 1 comment
Labels
Fix Ready A fix for this issue is ready for merging and testing Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Scripts Relates to scripted elements

Comments

@Constellation-VASCO
Copy link
Collaborator

MQ 101 starts MQ tutorial quest after character creation, instead of once you are orbit, causing it to fail to register multiple events. As a result, multiple tutorial messages are never displayed.


Details

MQ101 (3448) - starts MQ_TutorialQuest (45640) at stage 155 (see fragments\quests\qf_mq101_00003448.psc, Fragment_Stage_0155_Item_02())
mq_tutorialquestscript ShipLowHealth() attempts to get the player ship reference and register for an actorvalue change. Since the player is not yet in orbit, this fails, and is never checked again.
It also fails to register for Self.RegisterForRemoteEvent(PlayerShip.GetShipRef() as ScriptObject, "OnShipSystemDamaged")

Interestingly, MQ101 also tries to start the quest at stage 400 and stage 605 as well. Since the quest is already started, it does not re-attempt to register for menus at that time.
MQ101 Stage 400 NAM2-notes, comments that the Tutorial Quest starts now.
Interestingly, most of the menus are either not accessible before stage 400, or else have conditions that prevent the tutorial from firing then. The only two menus that seem to fire at that point are inventory menu (never has a tutorial and then deregisters) and skills menu (which talks about perk point assignment, even though you haven't leveled up by then so can't assign a perk point).

400 seems like a better stage to start it.

Game Version

1.8.86.0

Language

English (EN)

New Game

Yes

Reproduction Steps

Start a new game through character creation and check the papyrus log

@Constellation-VASCO Constellation-VASCO added Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Scripts Relates to scripted elements labels Dec 3, 2023
@TESWartortle
Copy link

TESWartortle commented Dec 16, 2023

MQ101 Tutorial Fix.zip

Edits VMAD to remove the following fragment:

Function Fragment_Stage_0155_Item_02()
  MQ_TutorialQuest.Start() ; #DEBUG_LINE_NO:1187
EndFunction

MQ_TutorialQuest should now be started at stage 400 by the following fragment:

Function Fragment_Stage_0400_Item_00()
  Quest __temp = Self as Quest ; #DEBUG_LINE_NO:1702
  mq101script kmyQuest = __temp as mq101script ; #DEBUG_LINE_NO:1703
  Game.RequestAutoSave() ; #DEBUG_LINE_NO:1706
  MQ101_013A_FlightScene.Start() ; #DEBUG_LINE_NO:1708
  Message.ClearHelpMessages() ; #DEBUG_LINE_NO:1711
  MQ_TutorialQuest.Start() ; #DEBUG_LINE_NO:1714
EndFunction

@TESWartortle TESWartortle added the Fix Ready A fix for this issue is ready for merging and testing label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Ready A fix for this issue is ready for merging and testing Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Scripts Relates to scripted elements
Projects
Status: Closed
Development

No branches or pull requests

2 participants