Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer of source of spelling and grammar fixes #726

Closed
Constellation-VASCO opened this issue Dec 6, 2023 · 17 comments
Closed

Offer of source of spelling and grammar fixes #726

Constellation-VASCO opened this issue Dec 6, 2023 · 17 comments
Labels
Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Missions & Dialogue Relates to missions (quests), NPC dialogue or player dialogue options

Comments

@Constellation-VASCO
Copy link
Collaborator

Constellation-VASCO commented Dec 6, 2023

I maintain a mod that SFCP could benefit from incorporating changes from


Details

I maintain "Starfiedl" which is a mod that fixes grammar and spelling errors, in Starfield, in NPC subtitles, player responses, slates, and terminals.

https://www.nexusmods.com/starfield/mods/7293

Beginning in version 2.0.0, which I hopefully will have ready for release later today, it will be split into multiple esms, with the base esm containing only fixes, and not purely-stylistic alterations, which will be moved to the optional esms.

The fixes in that base esm are the kinds of fixes SFCP includes, and this is me giving the SFCP project my permission to use the changes in that, in SFCP, whether it be by copying them into the SFCP esm, including the Starfiedl-Base.esm file as part of SFCP, or however best fits the needs of the project. Just please mention me (dodexahedron) and my mod :)

Seems to make more sense to me to just make you aware of this and grant permission, so y'all can just bulk add whatever you want from it before release of a new SFCP version, rather than me cluttering up the issue tracker with a ton of "fix this record" issues, for everything.

In the future, I plan to provide a version of my mod that specifies SFCP as a master and is cleaned against it, since there are likely to be plenty of conflicts, especially as both projects grow.

I am only doing this for the English version, and I use an en_US dialect.

Game Version

1.8.86.0

Language

English (EN)

New Game

Yes

Reproduction Steps

Play the game

Start a project to fix things

File this exact issue

@Constellation-VASCO Constellation-VASCO added Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Missions & Dialogue Relates to missions (quests), NPC dialogue or player dialogue options labels Dec 6, 2023
@Constellation-VASCO
Copy link
Collaborator Author

Thanks! Do you have a list of the typos you fixed that can easily be copied into the changelog?

@Pickysaurus Pickysaurus added the Fix Ready A fix for this issue is ready for merging and testing label Dec 8, 2023
@Constellation-VASCO
Copy link
Collaborator Author

I have actually separated them out into one esm now with version 2 of Starfiedl, which I released yesterday.

I don't have a text list of them, though, no.

As far as getting them into SFCP goes, it should be pretty much a matter of loading the Starfiedl-Base.esm in xEdit and just bulk-copying anything in it.

If y'all don't want to have to specifically call out each individual fix, that's fine with me.

@Constellation-VASCO
Copy link
Collaborator Author

Also

I know you MIT-license this, so I can do this without notice, but I just wanted to say that, if or when I start providing a version of my mod that specifies SFCP as master (I will always have one that doesn't, so users can pick the conflict winner), I intend for that version to have any conflicting records in SFCP that modify other parts of the same records (like conditions or other non-text/non-facial animation changes on the INFO records) copied for override into it, so that both the SFCP fixes and my edits/enhancements can coexist (a patch release, essentially). That version will, however, also be cleaned against SFCP, so that situation is unlikely to be terribly common, especially if y'all take any of my optional enhancements like facial animations as well (which you're welcome to do, as well, as you please).

As for attribution, unless you really want to call out each specific change, I've got no problem with changes lifted from my mod to be mentioned as a bulk item.

@Constellation-VASCO
Copy link
Collaborator Author

I've also started adding loading screens to this, as well, starting with 2.3.0, which was released just a few minutes ago.

@Constellation-VASCO
Copy link
Collaborator Author

I've just been going through your fixes and appreciate the effort. I don't think I'll be forwarding everything as some of them seem to be quite subjective.

@Constellation-VASCO
Copy link
Collaborator Author

To provide an example:
Original

The MAST district was named for the Military, Administrative and Scientific Triumvirate building, which stands as not only the center of New Atlantis, but the United Colonies as a whole.

Your fix

The MAST district was named for the Military, Administrative and Scientific Triumvirate building, which stands as not only the center of New Atlantis, but the United Colonies**,** as a whole.

In this example, the added comma seems to disrupt the flow of the sentence. If I read it aloud the original seems more natural.

@Constellation-VASCO
Copy link
Collaborator Author

I've merged in a few fixes, will leave this open to revisit. Was getting a bit of RSI reviewing them all >.<

@Constellation-VASCO
Copy link
Collaborator Author

That one, in particular, is a necessary comma, grammatically.

The ones I put into the base esm I check in Word on the formal writing setting, to be sure I'm not doing something grammatically incorrect.

When I do make any edits for subjective reasons like how I think the sentence should flow and such, they go in the optional esms. The exception is that, for the base module, I actually omit some of the commas that "should" be there, in some subtitles, because it ends up looking suuuuuuper choppy, with some of the lovely sentences they constructed in a few places.

Thanks for the shoutouts. 😅

It's funny to see them all collected like that. I knew I had tons, but damn. And I still haven't left New Homestead, yet, for the stuff I'm still working on at the moment. That tour is.... a lot...

You can continue to expect semi-frequent releases, so feel free to grab and diff or whatever your process is whenever it's convenient for ya. I'd suggest probably staying away from either one of the optional esms (though the PC one I think is pretty harmless - I just hate how rudely terse the player is in the writing in SF).

I've touched a few loading screens, too, but I'm sure you'll see that whenever you look at it.

2.4 or 2.5 or whatever I'm about to be up to should be out in the next day or two.

@dodexahedron
Copy link

dodexahedron commented Dec 15, 2023

Was getting a bit of RSI reviewing them all >.<

Haha. Now imagine how I feel, listening to the conversations, pausing, editing, exiting game, saving, and repeating to play-test and refine, over and over and over and over. 😂

I mean I typically do it in like batches of 10 or so before reloading, but that still means at least a dozen reloads just for that, in like a 2-hour session.

@dodexahedron
Copy link

Oh jeez. 🤦‍♂️

Senior moment.

Went back through the change log and saw that you already saw the addition of the loading screens. 😅

@dodexahedron
Copy link

And I just realized that loading screen where I changed the odd "rarely" to "occasionally" has one other oddity.

Why did they bother saying "dead in the water" and not...ya know... "dead in space," without air quotes? Who is playing a space game and wouldn't understand "dead in space?" 🤨

@dodexahedron
Copy link

dodexahedron commented Dec 16, 2023

I abhor the writing in the New Homestead museum, on the displays. Aside from several misspellings, it's just awkward, inconsistent, and unrealistic, and even a little bit inaccurate in one or two places.

Like really? You need to air quote "ice skate" and explain what an ice skate is? No. Sorry. Especially with all the frozen wastelands people live in, in SF, I promise everyone knows what an ice skate is. That hockey display also makes it sound like a hockey team is 5 players and 2 goalies (and they also felt it necessary to explain the word "goalie"). Come TF on... Sports still exist, I promise.

Or like... The "NASA" display? For one, it's not all NASA, and the Vostok 1 model in the case is a pretty big deal, being the first manned orbital spaceflight, with a freaking planet named after the pilot, in the game (Yuri Gagarin). And Apollo 11 was a mission. The model in there is the LM, CM, and SM. So, I re-titled that display and added details. 
Anyway...

I cleaned those up a lot and did some heavy re-wording on a couple. Some edits are in base and others are in the optional terminal enhancements module, but I kinda think all of them are worth considering for SFCP, at least.

Those will be in my next release.

@Constellation-VASCO
Copy link
Collaborator Author

I realise this is immensely pedantic, but I think Picky's instinct about the comma in that sentence is correct. It certainly doesn't match the flow of the sentence and a cursory search found no binding rule in support of the comma placement. I think in these cases it's wiser to err on the side if caution (i.e. not change anything), rather than adding awkward commas just because Word said so.

@dodexahedron
Copy link

You know what? You're both right. I was mis-applying two rules that got combined and then muddled in my head, for prepositional phrases and dependent clauses. That one is just a plain ol' dependent clause, and they only need commas if they come before their associated independent clauses. Good call. I'll take it out of my mod, too.

As for Word: I only use it for confirmation that something isn't incorrect - not to make the actual changes. But, since that edit was also not incorrect (it is only discouraged by modern style guides), it was not flagged as an error. I'll remove that edit anyway, since I had only added it under the impression it was necessary in the first place.

@Constellation-VASCO
Copy link
Collaborator Author

2.4.0 released today, with a bunch of edits and fixes, including removing the loading screen edit pointed out here.

I'm finally going to be leaving New Homestead! 🥳😅

@Constellation-VASCO
Copy link
Collaborator Author

Oh yeah, also...

If it'll make your life any easier, I'm now dumping each version with Spriggit and posting it all on GitHub, here: https://github.com/dodexahedron/Starfiedl

Might reduce the workload for diffing, at least.

@Pickysaurus Pickysaurus removed the Fix Ready A fix for this issue is ready for merging and testing label Mar 11, 2024
@Pickysaurus
Copy link
Member

Thanks for contributing. Several of your fixes have been rolled in to 0.1.0 and 0.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Missions & Dialogue Relates to missions (quests), NPC dialogue or player dialogue options
Projects
Status: Closed
Development

No branches or pull requests

3 participants