Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starborn Guardian Missing Vertical Landing Anims #892

Closed
Constellation-VASCO opened this issue Mar 2, 2024 · 1 comment
Closed

Starborn Guardian Missing Vertical Landing Anims #892

Constellation-VASCO opened this issue Mar 2, 2024 · 1 comment
Labels
Fix Ready A fix for this issue is ready for merging and testing Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Animations Relates to animations

Comments

@Constellation-VASCO
Copy link
Collaborator

If you attempt to land or take off from a "vertical" landing pad with a Starborn ship, such as the one at Gagarin Landing, the sequence will fail to play correctly. It will show the world glitching out for a second, before teleporting you directly into space. This is because the Starborn ships are missing "vertical" takeoff and landing animations.


Details

For landing, no special animation is really needed with this ship, as the standard animation is already just a vertical descent. By adding a condition of Subject.HasKeyword(ShipTypeStarborn [KYWD:0033DB7A]) = 0 to the Ship_Landing_Vertical [IDLE:0010A3C4] animation record, we cause the game to fall back to the standard landing animation for Starborn ships specifically, which looks perfectly fine.

For taking off, we need an animation which is equivalent to the "vertical" takeoff animations that other ships use. One which causes the ship to gain more altitude than usual before flying forward, and into orbit. Luckily, such an animation already exists for the Starborn ship with the Neon landing pad specifically. So if we modify the conditions of ShipTakeOffNeonStarborn to be true with the Neon pad, OR with Vertical pads, we can see a proper non-clipping takeoff at those locations too. The same tweak should be made to the SpaceshipTakeOffStarbornNeon_Pad01 camera path too, so that the camera view isn't too low during vertical pad takeoffs.

Game Version

1.9.67.0

Language

English (EN)

New Game

Yes

Reproduction Steps

Land your Starborn ship at Gagarin Landing. There will be no landing animation. Then try to take off, and you will see a glitchy sequence before being teleported into space.

@Constellation-VASCO Constellation-VASCO added Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Animations Relates to animations labels Mar 2, 2024
@Constellation-VASCO
Copy link
Collaborator Author

@Pickysaurus Pickysaurus added the Fix Ready A fix for this issue is ready for merging and testing label Mar 8, 2024
Pickysaurus added a commit that referenced this issue Mar 10, 2024
Fixes #822
Fixes #892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Ready A fix for this issue is ready for merging and testing Platform: PC (Steam) This issue is being reported from the PC release of Starfield on Steam Type: Animations Relates to animations
Projects
Status: Closed
Development

No branches or pull requests

2 participants