Fix mapqkz #11
Closed
Fix mapqkz #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as Patrick Wallace pointed out in an email, p2 is converted to spherical coordinates almost immediately after being computed, so its normalization is irrelevant
(it was already in mapqkz)
|
With the removal of the normalization, is the local variable p1dvp1 no longer required? |
|
I have removed the unused variable. |
|
I applied the changes to the master branch. |
|
@grahambell Great. Thanks. Can a new release be tagged? I would like to incorporate this into PALPYY (and then into the LSST software stack). LSST policy is to only include tagged releases of third party packages. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapqkz was missing the block of code that, in mapqk, accounts for light-deflection near the Sun. After corresponding with Patrick Wallace, I added that code into mapqkz. I then rewrote the unit tests for mapqk and mapqkz. The test for mapqk now takes USNO data for the geocentric apparent position of Arcturus and tries to calculate it from Acturus' mean position and motion parameters. The test for mapqkz sends identical inputs through mapqk and mapqkz and verifies that the same result comes out.