Skip to content

Commit

Permalink
ttools: add missing getLongArrayProperty method to JELRowReader
Browse files Browse the repository at this point in the history
The absence of this method meant that JEL expressions attempting to
subscript long arrays failed.  I'm 95% sure that its omission in
the first place was just an oversight rather than for some subtle
JEL reason.
  • Loading branch information
mbtaylor committed Oct 24, 2013
1 parent 317360e commit 40f1aaa
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 0 deletions.
2 changes: 2 additions & 0 deletions topcat/src/docs/sun253.xml
Expand Up @@ -18240,6 +18240,8 @@ introduced since the last version:
in multi-SIA/SSA windows.</li>
<li>URL selector fields in Activation Action window are now
editable.</li>
<li>Fix bug which prevented access to long integer array elements
from expression language.</li>
</ul>
</p></dd>

Expand Down
2 changes: 2 additions & 0 deletions ttools/src/docs/sun256.xml
Expand Up @@ -8422,6 +8422,8 @@ eds. C. Gabriel et al., ASP Conf. Ser. 351, p. 666 (2006)
<li>Add some more colour maps.</li>
<li>Fix some broken and misdocumented non-table-output JyStilts
commands (<code>tcube</code>, <code>pixfoot</code>).</li>
<li>Fix bug which prevented access to long integer array elements
from expression language.</li>
</ul>
</p></dd>
</dl>
Expand Down
5 changes: 5 additions & 0 deletions ttools/src/main/uk/ac/starlink/ttools/jel/JELRowReader.java
Expand Up @@ -683,6 +683,11 @@ public int[] getIntArrayProperty( int id ) {
? (int[]) getObjectColumnValue( id )
: (int[]) getConstantValue( -1 - id );
}
public long[] getLongArrayProperty( int id ) {
return id >= 0
? (long[]) getObjectColumnValue( id )
: (long[]) getConstantValue( -1 -id );
}
public float[] getFloatArrayProperty( int id ) {
return id >= 0
? (float[]) getObjectColumnValue( id )
Expand Down

0 comments on commit 40f1aaa

Please sign in to comment.