Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple stringification of request parameters #1397

Closed
elvece opened this issue Apr 14, 2022 · 0 comments · Fixed by #1414
Closed

Multiple stringification of request parameters #1397

elvece opened this issue Apr 14, 2022 · 0 comments · Fixed by #1414
Assignees
Labels
Bug Something isn't working P2 - Desirable high prioity, nice-to-haves UI Issues pertaining to any of the embassy-served web applications
Milestone

Comments

@elvece
Copy link
Member

elvece commented Apr 14, 2022

Bug:
When switching to a different marketplace within the UI and loading a different version of a package, the request failing with the following error:

Error
Invalid Request {"code":"INVALID_PARAMS","message":"Could not parse request parameters get:ids: \"\\\"\\\\\\\"[{\\\\\\\\\\\\\\\"id\\\\\\\\\\\\\\\":\\\\\\\\\\\\\\\"bitcoind\\\\\\\\\\\\\\\",\\\\\\\\\\\\\\\"version\\\\\\\\\\\\\\\":\\\\\\\\\\\\\\\"22.0.0\\\\\\\\\\\\\\\"}]\\\\\\\"\\\"\""}

The params are invalid to the registry because the ids value is stringifed multiple times and cannot be parsed as json from the backend perspective.

This state can be repaired by logging out and hard refreshing. The likely theory for this bug is a caching issue, having to do with RxJS observables on initial load of getting marketplace data.

Steps to recreate:

  1. Menu > Embassy > Marketplace Settings > + Add Alt Marketplace > Connect to Marketplace
  2. Menu > Marketplace > Select an installed Service > Additional Info > Other Versions > Select another version > OK > See error display in red outlined toast (see screenshots)

Request:
Screen Shot 2022-04-14 at 11 48 55 AM

Response:
Screen Shot 2022-04-14 at 11 49 06 AM

@elvece elvece added Bug Something isn't working UI Issues pertaining to any of the embassy-served web applications P2 - Desirable high prioity, nice-to-haves labels Apr 14, 2022
@elvece elvece added this to the 0.3.1 milestone Apr 14, 2022
@elvece elvece self-assigned this Apr 14, 2022
@elvece elvece mentioned this issue Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working P2 - Desirable high prioity, nice-to-haves UI Issues pertaining to any of the embassy-served web applications
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant